r75318 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75317‎ | r75318 | r75319 >
Date:16:59, 24 October 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Moved gateway definition for activeMQ out of hardcoded string in activemq - now gets set in payflowpro_gateway.body.php
Modified paths:
  • /trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -982,6 +982,7 @@
983983 'contribution_tracking_id' => $wgRequest->getText( 'contribution_tracking_id' ),
984984 'data_hash' => $wgRequest->getText( 'data_hash' ),
985985 'action' => $wgRequest->getText( 'action' ),
 986+ 'gateway' => 'payflowpro',
986987 );
987988 } else {
988989 $data = array(
@@ -1018,6 +1019,7 @@
10191020 'contribution_tracking_id' => $wgRequest->getText( 'contribution_tracking_id' ),
10201021 'data_hash' => $wgRequest->getText( 'data_hash' ),
10211022 'action' => $wgRequest->getText( 'action' ),
 1023+ 'gateway' => 'payflowpro', // this may need to become dynamic in the future
10221024 );
10231025 }
10241026 return $data;
Index: trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php
@@ -163,7 +163,7 @@
164164 'country' => $transaction['country_name'],
165165 'countryID' => $transaction['country_code'],
166166 'postal_code' => $transaction['zip'],
167 - 'gateway' => 'payflowpro',
 167+ 'gateway' => $transaction[ 'gateway' ],
168168 'gateway_txn_id' => $transaction['PNREF'],
169169 'response' => $transaction['RESPMSG'],
170170 'currency' => $transaction['currency'],

Status & tagging log