r75310 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75309‎ | r75310 | r75311 >
Date:14:57, 24 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r75309
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMapsFormInput.php
@@ -46,7 +46,7 @@
4747 */
4848 protected function addFormDependencies() {
4949 global $wgOut;
50 - global $smgScriptPath, $smgYahooFormsOnThisPage, $smgStyleVersion;
 50+ global $smgScriptPath, $smgStyleVersion;
5151
5252 $this->service->addDependency( Html::linkedScript( "$smgScriptPath/includes/services/YahooMaps/SM_YahooMapsForms.js?$smgStyleVersion" ) );
5353 $this->service->addDependencies( $wgOut );
Index: trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayersFormInput.php
@@ -24,7 +24,7 @@
2525 */
2626 protected function addFormDependencies() {
2727 global $wgOut;
28 - global $smgScriptPath, $smgOLFormsOnThisPage, $smgStyleVersion;
 28+ global $smgScriptPath, $smgStyleVersion;
2929
3030 $this->service->addDependency( Html::linkedScript( "$smgScriptPath/includes/services/OpenLayers/SM_OpenLayersForms.js?$smgStyleVersion" ) );
3131 $this->service->addDependencies( $wgOut );
Index: trunk/extensions/SemanticMaps/includes/services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -1,23 +1,9 @@
22 <?php
33
44 /**
5 - * File holding the SMGoogleMapsFormInput class.
6 - *
7 - * @file SM_GoogleMapsFormInput.php
8 - * @ingroup SMGoogleMaps
9 - *
10 - * @author Jeroen De Dauw
11 - * @author Robert Buzink
12 - * @author Yaron Koren
13 - */
14 -
15 -if ( !defined( 'MEDIAWIKI' ) ) {
16 - die( 'Not an entry point.' );
17 -}
18 -
19 -/**
205 * Class for Google Maps v2 form inputs.
216 *
 7+ * @file SM_GoogleMapsFormInput.php
228 * @ingroup SMGoogleMaps
239 *
2410 * @author Jeroen De Dauw
@@ -50,7 +36,7 @@
5137 */
5238 protected function addFormDependencies() {
5339 global $wgOut;
54 - global $smgScriptPath, $smgGoogleFormsOnThisPage, $smgStyleVersion;
 40+ global $smgScriptPath, $smgStyleVersion;
5541
5642 $this->service->addDependency( Html::linkedScript( "$smgScriptPath/includes/services/GoogleMaps/SM_GoogleMapsForms.js?$smgStyleVersion" ) );
5743 $this->service->addDependencies( $wgOut );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75309Some cleanupjeroendedauw14:56, 24 October 2010

Status & tagging log