r75259 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75258‎ | r75259 | r75260 >
Date:16:14, 23 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup r74098, fixup extensions that are using getTokenSalt, by adding needsToken
Modified paths:
  • /trunk/extensions/FlaggedRevs/api/ApiReview.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/ApiStabilize.php (modified) (history)
  • /trunk/extensions/LiquidThreads/api/ApiThreadAction.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/api/ApiThreadAction.php (modified) (history)
  • /trunk/extensions/Reflect/server/api/ApiReflectAction.php (modified) (history)
  • /trunk/extensions/Reflect/server/api/ApiReflectStudyAction.php (modified) (history)
  • /trunk/extensions/WikiAtHome/ApiWikiAtHome.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MultilingualLiquidThreads/LiquidThreads/api/ApiThreadAction.php
@@ -765,6 +765,10 @@
766766 return array(
767767 );
768768 }
 769+
 770+ public function needsToken() {
 771+ return true;
 772+ }
769773
770774 public function getTokenSalt() {
771775 return '';
Index: trunk/extensions/WikiAtHome/ApiWikiAtHome.php
@@ -301,6 +301,10 @@
302302 'Note that the HTTP POST must be done as a file upload (i.e. using multipart/form-data)'
303303 );
304304 }
 305+
 306+ public function needsToken() {
 307+ return true;
 308+ }
305309
306310 public function getTokenSalt() {
307311 return '';
Index: trunk/extensions/Reflect/server/api/ApiReflectAction.php
@@ -542,6 +542,10 @@
543543 return array();
544544 }
545545
 546+ public function needsToken() {
 547+ return true;
 548+ }
 549+
546550 public function getTokenSalt() {
547551 return '';
548552 }
Index: trunk/extensions/Reflect/server/api/ApiReflectStudyAction.php
@@ -181,6 +181,10 @@
182182 return array();
183183 }
184184
 185+ public function needsToken() {
 186+ return true;
 187+ }
 188+
185189 public function getTokenSalt() {
186190 return '';
187191 }
Index: trunk/extensions/LiquidThreads/api/ApiThreadAction.php
@@ -883,6 +883,10 @@
884884 return array(
885885 );
886886 }
 887+
 888+ public function needsToken() {
 889+ return true;
 890+ }
887891
888892 public function getTokenSalt() {
889893 return '';
Index: trunk/extensions/FlaggedRevs/api/ApiReview.php
@@ -196,8 +196,12 @@
197197 array( 'code' => 'syncfailure', 'info' => 'A sync failure has occured while reviewing. Please try again.' ),
198198 ) );
199199 }
200 -
201 - public function getTokenSalt() {
 200+
 201+ public function needsToken() {
 202+ return true;
 203+ }
 204+
 205+ public function getTokenSalt() {
202206 return '';
203207 }
204208
Index: trunk/extensions/FlaggedRevs/api/ApiStabilize.php
@@ -58,6 +58,10 @@
5959 return true;
6060 }
6161
 62+ public function needsToken() {
 63+ return true;
 64+ }
 65+
6266 public function getTokenSalt() {
6367 return '';
6468 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74098* (bug 25248) API: paraminfo errors with certain modules...reedy20:12, 1 October 2010

Status & tagging log