r75246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75245‎ | r75246 | r75247 >
Date:15:16, 23 October 2010
Author:demon
Status:ok
Tags:
Comment:
Fix a few visibilities, add a @todo
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -232,6 +232,8 @@
233233 /**
234234 * Register tag hook below.
235235 *
 236+ * @todo Move this to WebInstaller with the two things below?
 237+ *
236238 * @param $parser Parser
237239 */
238240 public function registerDocLink( Parser &$parser ) {
@@ -288,7 +290,7 @@
289291 *
290292 * @return Status
291293 */
292 - public function installExtensions() {
 294+ protected function installExtensions() {
293295 $exts = $this->getVar( '_Extensions' );
294296 $path = $this->getVar( 'IP' ) . '/extensions';
295297
@@ -305,7 +307,7 @@
306308 *
307309 * @return array
308310 */
309 - public function getInstallSteps() {
 311+ protected function getInstallSteps() {
310312 if( $this->getVar( '_UpgradeDone' ) ) {
311313 $this->installSteps = array( 'localsettings' );
312314 }
@@ -369,7 +371,7 @@
370372 *
371373 * @return Status
372374 */
373 - public function installSecretKey() {
 375+ protected function installSecretKey() {
374376 if ( wfIsWindows() ) {
375377 $file = null;
376378 } else {
@@ -403,7 +405,7 @@
404406 *
405407 * @return Status
406408 */
407 - public function installSysop() {
 409+ protected function installSysop() {
408410 $name = $this->getVar( '_AdminName' );
409411 $user = User::newFromName( $name );
410412

Status & tagging log