r75221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75220‎ | r75221 | r75222 >
Date:23:13, 22 October 2010
Author:yaron
Status:deferred
Tags:
Comment:
Minor formatting changes, fixed bug in cache handling
Modified paths:
  • /trunk/extensions/ExternalData/ED_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExternalData/ED_Utils.php
@@ -42,7 +42,7 @@
4343 static function parseParams( $params ) {
4444 $args = Array();
4545 foreach ( $params as $param ) {
46 - $param = preg_replace ( "/\s\s+/" , " " , $param ); // whitespace
 46+ $param = preg_replace ( "/\s\s+/", ' ', $param ); // whitespace
4747 $param_parts = explode( "=", $param, 2 );
4848 if ( count( $param_parts ) < 2 ) {
4949 continue;
@@ -57,7 +57,7 @@
5858 * Parses an argument of the form "a=b,c=d,..." into an array
5959 */
6060 static function paramToArray( $arg, $lowercaseKeys = false, $lowercaseValues = false ) {
61 - $arg = preg_replace ( "/\s\s+/" , ' ', $arg ); // whitespace
 61+ $arg = preg_replace ( "/\s\s+/", ' ', $arg ); // whitespace
6262 $keyValuePairs = explode( ',', $arg );
6363 $returnArray = Array();
6464 foreach ( $keyValuePairs as $keyValuePair ) {
@@ -426,7 +426,6 @@
427427 return $page;
428428 }
429429 } else {
430 - $row = $dbr->fetchObject( $res );
431430 return $row->result;
432431 }
433432 }

Status & tagging log