r75201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75200‎ | r75201 | r75202 >
Date:16:27, 22 October 2010
Author:yaron
Status:deferred
Tags:
Comment:
Added ID for form, fix for 'sfHTMLBeforeForm' hook
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -230,11 +230,11 @@
231231 $text .= "</div>\n";
232232 }
233233 $text .= <<<END
234 - <form name="createbox" onsubmit="return validate_all()" action="" method="post" class="createbox">
 234+ <form name="createbox" id="sfForm" action="" method="post" class="createbox">
235235
236236 END;
237237 $pre_form_html = '';
238 - wfRunHooks( 'sfHTMLBeforeForm', array( &$page_title, &$pre_form_html ) );
 238+ wfRunHooks( 'sfHTMLBeforeForm', array( &$target_title, &$pre_form_html ) );
239239 $text .= $pre_form_html;
240240 $text .= $form_text;
241241 }
@@ -250,7 +250,7 @@
251251 // $wgOut->addScript(' <script type="text/javascript">' . "\n" . $javascript_text . '</script>' . "\n");
252252 $wgOut->addHTML( $text );
253253 if ( ! empty( $javascript_text ) ) {
254 - $wgOut->addHTML( ' <script type="text/javascript">' . "\n" . $javascript_text . '</script>' . "\n" );
 254+ $wgOut->addHTML( ' <script type="text/javascript">' . "\n$javascript_text\n" . '</script>' . "\n" );
255255 }
256256 }
257257

Status & tagging log