| Index: trunk/extensions/Wikilog/WikilogCommentsPage.php |
| — | — | @@ -29,6 +29,12 @@ |
| 30 | 30 | if ( !defined( 'MEDIAWIKI' ) ) |
| 31 | 31 | die(); |
| 32 | 32 | |
| | 33 | +# NOTE (Mw1.16- COMPAT): GAID_FOR_UPDATE removed and replaced by |
| | 34 | +# Title::GAID_FOR_UPDATE in Mw1.17. Remove this define and replace its |
| | 35 | +# occurrence WikilogCommentsPage::setCommentApproval() in Wl1.3. |
| | 36 | +if ( !defined( 'GAID_FOR_UPDATE' ) ) |
| | 37 | + define( 'GAID_FOR_UPDATE', Title::GAID_FOR_UPDATE ); |
| | 38 | + |
| 33 | 39 | /** |
| 34 | 40 | * Wikilog comments namespace handler class. |
| 35 | 41 | * |
| — | — | @@ -377,6 +383,10 @@ |
| 378 | 384 | array( 'id' => 'wl-comment-form' ) ) . "\n"; |
| 379 | 385 | } |
| 380 | 386 | |
| | 387 | + /** |
| | 388 | + * @todo (In Wikilog 1.3.x) Replace GAID_FOR_UPDATE with |
| | 389 | + * Title::GAID_FOR_UPDATE. |
| | 390 | + */ |
| 381 | 391 | protected function setCommentApproval( $comment, $approval ) { |
| 382 | 392 | global $wgOut, $wgUser; |
| 383 | 393 | |
| — | — | @@ -399,7 +409,7 @@ |
| 400 | 410 | array( 'content', 'parsemag' ), |
| 401 | 411 | $comment->mUserText |
| 402 | 412 | ); |
| 403 | | - $id = $title->getArticleID( Title::GAID_FOR_UPDATE ); |
| | 413 | + $id = $title->getArticleID( GAID_FOR_UPDATE ); |
| 404 | 414 | if ( $this->doDeleteArticle( $reason, false, $id ) ) { |
| 405 | 415 | $comment->deleteComment(); |
| 406 | 416 | $log->addEntry( 'c-reject', $title, '' ); |
| Index: trunk/extensions/Wikilog/TODO |
| — | — | @@ -17,3 +17,10 @@ |
| 18 | 18 | * WikilogTemplatePager::formatRow(): Remove {{{pubdate}}} and {{{updated}}}. |
| 19 | 19 | * Remove wfLoadExtensionMessages() calls. |
| 20 | 20 | * Replace Xml::hidden() calls with Html::hidden(). |
| | 21 | + |
| | 22 | +=== Wikilog 1.3.0. |
| | 23 | + |
| | 24 | +* Drop support for Mw1.16 and earlier. |
| | 25 | +* Remove Mw1.16 compatibility boilerplate in: |
| | 26 | + - WikilogComment::getCommentArticleTitle() (GAID_FOR_UPDATE). |
| | 27 | + - WikilogCommentsPage::setCommentApproval() (GAID_FOR_UPDATE). |
| Index: trunk/extensions/Wikilog/WikilogComment.php |
| — | — | @@ -29,6 +29,12 @@ |
| 30 | 30 | if ( !defined( 'MEDIAWIKI' ) ) |
| 31 | 31 | die(); |
| 32 | 32 | |
| | 33 | +# NOTE (Mw1.16- COMPAT): GAID_FOR_UPDATE removed and replaced by |
| | 34 | +# Title::GAID_FOR_UPDATE in Mw1.17. Remove this define and replace its |
| | 35 | +# occurrence WikilogComment::getCommentArticleTitle() in Wl1.3. |
| | 36 | +if ( !defined( 'GAID_FOR_UPDATE' ) ) |
| | 37 | + define( 'GAID_FOR_UPDATE', Title::GAID_FOR_UPDATE ); |
| | 38 | + |
| 33 | 39 | /** |
| 34 | 40 | * Wikilog article comment database entry. |
| 35 | 41 | */ |
| — | — | @@ -238,12 +244,14 @@ |
| 239 | 245 | |
| 240 | 246 | /** |
| 241 | 247 | * Returns comment article title. |
| | 248 | + * @todo (In Wikilog 1.3.x) Replace GAID_FOR_UPDATE with |
| | 249 | + * Title::GAID_FOR_UPDATE. |
| 242 | 250 | */ |
| 243 | 251 | public function getCommentArticleTitle() { |
| 244 | 252 | if ( $this->mCommentTitle ) { |
| 245 | 253 | return $this->mCommentTitle; |
| 246 | 254 | } else if ( $this->mCommentPage ) { |
| 247 | | - return Title::newFromID( $this->mCommentPage, Title::GAID_FOR_UPDATE ); |
| | 255 | + return Title::newFromID( $this->mCommentPage, GAID_FOR_UPDATE ); |
| 248 | 256 | } else { |
| 249 | 257 | $it = $this->mItem->mTitle; |
| 250 | 258 | return Title::makeTitle( |