r75171 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75170‎ | r75171 | r75172 >
Date:21:33, 21 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Renamed vector and monobook modules to skins.vector and skins.monobook - a convention that should be followed in the future for other skins.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -48,7 +48,7 @@
4949 */
5050 function setupSkinUserCss( OutputPage $out ){
5151 parent::setupSkinUserCss( $out );
52 - $out->addModuleStyles( 'vector' );
 52+ $out->addModuleStyles( 'skins.vector' );
5353 }
5454
5555 /**
Index: trunk/phase3/skins/MonoBook.php
@@ -28,7 +28,7 @@
2929
3030 parent::setupSkinUserCss( $out );
3131
32 - $out->addModuleStyles( 'monobook' );
 32+ $out->addModuleStyles( 'skins.monobook' );
3333
3434 // TODO: Migrate all of these
3535 //$out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
Index: trunk/phase3/resources/Resources.php
@@ -11,10 +11,10 @@
1212
1313 /* Skins */
1414
15 - 'vector' => new ResourceLoaderFileModule(
 15+ 'skins.vector' => new ResourceLoaderFileModule(
1616 array( 'styles' => array( 'skins/vector/screen.css' => array( 'media' => 'screen' ) ) )
1717 ),
18 - 'monobook' => new ResourceLoaderFileModule(
 18+ 'skins.monobook' => new ResourceLoaderFileModule(
1919 array( 'styles' => array(
2020 'skins/monobook/main.css' => array( 'media' => 'screen' ),
2121 // Honor $wgHandheldStyle. This is kind of evil

Status & tagging log