r75169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75168‎ | r75169 | r75170 >
Date:20:55, 21 October 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Synced files from r75137 to r75167 of trunk
Modified paths:
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/includes (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/includes/paypal.png (added) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php
@@ -41,7 +41,7 @@
4242 // add noscript tags for javascript disabled browsers
4343 $form .= $this->getNoScript();
4444
45 - $form .= Xml::tags( 'h2', array( 'id' => 'donate-head' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
 45+ // $form .= Xml::tags( 'h2', array( 'id' => 'donate-head' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
4646
4747 // provide a place at the top of the form for displaying general messages
4848 if ( $this->form_errors['general'] ) {
@@ -90,8 +90,8 @@
9191 if ( !$this->paypal ) {
9292 // PayPal button
9393 $form .= '<tr>';
94 - $form .= '<td class="label"></td>';
95 - $form .= '<td><a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';document.payment.submit();"><img src="'.$scriptPath.'/donate_with_paypal.gif"/></a></td>';
 94+ $form .= '<td style="text-align:center;" colspan="2"><big><b>Donate via PayPal</b></big><br/><a href="#" onclick="document.payment.PaypalRedirect.value=\'true\';document.payment.submit();"><img src="'.$scriptPath.'/paypal.png"/></a><br/>'.
 95+ '— or —<br/><big><b>Donate on Wikipedia</b></big></td>';
9696 $form .= '</tr>';
9797 }
9898
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php
___________________________________________________________________
Added: svn:mergeinfo
9999 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php:r75105-75166
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
@@ -19,11 +19,13 @@
2020 // form placeholder values
2121 $first = wfMsg( 'payflowpro_gateway-first' );
2222 $last = wfMsg( 'payflowpro_gateway-last' );
 23+ $other = wfMsg( 'payflowpro_gateway-other' );
2324 $js = <<<EOT
2425 <script type="text/javascript">
2526 function loadPlaceholders() {
2627 var fname = document.getElementById('fname');
2728 var lname = document.getElementById('lname');
 29+ var otherRadio = document.getElementById('otherRadio');
2830 var amountOther = document.getElementById('amountOther');
2931 if (fname.value == '') {
3032 fname.style.color = '#999999';
@@ -33,6 +35,10 @@
3436 lname.style.color = '#999999';
3537 lname.value = '$last';
3638 }
 39+ if (typeof otherRadio != "undefined" && amountOther.value == '') {
 40+ amountOther.style.color = '#999999';
 41+ amountOther.value = '$other';
 42+ }
3743 }
3844 addEvent( window, 'load', loadPlaceholders );
3945 </script>
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
___________________________________________________________________
Added: svn:mergeinfo
4046 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php:r75105-75166
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/includes/paypal.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/includes/paypal.png
___________________________________________________________________
Added: svn:mime-type
4147 + application/octet-stream
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/includes
___________________________________________________________________
Added: svn:mergeinfo
4248 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/includes:r75105-75167
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -108,6 +108,7 @@
109109 'payflowpro_gateway-comment' => 'Comment',
110110 'payflowpro_gateway-first' => 'First',
111111 'payflowpro_gateway-last' => 'Last',
 112+ 'payflowpro_gateway-other' => 'Other',
112113 'payflowpro_gateway-noscript-msg' => 'It appears that you do not have JavaScript enabled, or your browser does not support it.
113114 In order to provide a safe, secure and pleasant experience, our donation form requires JavaScript.',
114115 'payflowpro_gateway-noscript-redirect-msg' => 'If you cannot or do not wish to enable JavaScript, you may still contribute by visiting:',
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
___________________________________________________________________
Added: svn:mergeinfo
115116 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php:r75105-75166

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75137Changed the way that ResourceLoaderFileModule and mediaWiki.loader work in de...tparscal01:03, 21 October 2010
r75167adding paypal buttonkaldari20:13, 21 October 2010

Status & tagging log