r75154 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75153‎ | r75154 | r75155 >
Date:14:34, 21 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Can't use Title::isSpecialPage without breaking bc with 1.15 :(
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Ask.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Ask.php
@@ -37,7 +37,8 @@
3838 $result = smwfEncodeMessages( array( wfMsgForContent( 'smw_iq_disabled' ) ) );
3939 }
4040
41 - if ( $wgTitle->isSpecialPage() ) {
 41+ // Starting from MW 1.16, there is a more suited method available: Title::isSpecialPage
 42+ if ( $wgTitle->getNamespace() == NS_SPECIAL ) {
4243 global $wgOut;
4344 SMWOutputs::commitToOutputPage( $wgOut );
4445 }

Status & tagging log