r75150 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75149‎ | r75150 | r75151 >
Date:13:25, 21 October 2010
Author:hartman
Status:deferred (Comments)
Tags:
Comment:
* A tooltab cannot be 100% height of its parent, because there is an <ul> sibling that takes up space.
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/tools/mw.SequencerTools.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/tools/mw.SequencerTools.js
——@@ -1086,7 +1086,6 @@
10871087 // Append the tooltab container
10881088 $toolsContainer.append(
10891089 $j('<div />')
1090 - .css({'height' : '100%' })
10911090 .attr('id', 'tooltab_' + toolId )
10921091 .append(
10931092 $j('<h3 />').text( gM('mwe-sequencer-tools-' + toolId + '-desc') )
——@@ -1275,4 +1274,4 @@
12761275 }
12771276 }
12781277
1279 -} )( window.mw );
\ No newline at end of file
 1278+} )( window.mw );

Comments

#Comment by TheDJ (talk | contribs)   13:30, 21 October 2010

with this height, the ul toc, became invisible, when there were multiple tooltabs. That seems undesirable and confusing to me.

Status & tagging log