r75141 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75140‎ | r75141 | r75142 >
Date:12:20, 21 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
appendIframe() uses encodeURIComponent to encode the anchor, so getClientRequest() should use decodeURIComponent, not unescape().
Modified paths:
  • /branches/MwEmbedStandAlone/modules/ApiProxy/mw.ApiProxy.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/ApiProxy/mw.ApiProxy.js
——@@ -555,7 +555,7 @@
556556 */
557557 function getClientRequest() {
558558 // Read the anchor data package from the requesting url
559 - var hashMsg = unescape( mw.parseUri( document.URL ).anchor );
 559+ var hashMsg = decodeURIComponent( mw.parseUri( document.URL ).anchor );
560560 try {
561561 return JSON.parse( hashMsg );
562562 } catch ( e ) {

Status & tagging log