r75031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75030‎ | r75031 | r75032 >
Date:19:58, 19 October 2010
Author:mglaser
Status:ok
Tags:
Comment:
Follow up r74753, removed pass-by-references and @ operator
Modified paths:
  • /trunk/phase3/maintenance/tests/selenium/SeleniumServerManager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/selenium/SeleniumServerManager.php
@@ -179,12 +179,13 @@
180180 // on its port. Note: this solution kinda
181181 // stinks, since it uses a wait loop - dnessett
182182
 183+ wfSuppressWarnings();
183184 for ( $cnt = 1;
184185 $cnt <= $this->SeleniumServerStartTimeout;
185186 $cnt++ ) {
186 - $fp = @fsockopen ( 'localhost',
 187+ $fp = fsockopen ( 'localhost',
187188 $this->SeleniumServerPort,
188 - &$errno, &$errstr, 0 );
 189+ $errno, $errstr, 0 );
189190 if ( !$fp ) {
190191 sleep( 1 );
191192 continue;
@@ -194,6 +195,7 @@
195196 return 'started';
196197 }
197198 }
 199+ wfRestoreWarnings();
198200 echo ( "Starting Selenium server timed out.\n" );
199201 return 'failed';
200202 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74753* start / stop selenium server on Linux...mglaser00:06, 14 October 2010

Status & tagging log