r75029 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75028‎ | r75029 | r75030 >
Date:19:38, 19 October 2010
Author:mglaser
Status:ok
Tags:
Comment:
Follow up r74750, array keys should be strings
Modified paths:
  • /trunk/phase3/maintenance/tests/selenium/SeleniumConfig.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/selenium/SeleniumConfig.php
@@ -70,14 +70,14 @@
7171 // inserts the section arrays into the appropriate places in
7272 // the SeleniumSettings and SeleniumTests arrays.
7373
74 - if ( isset( $configArray[browsers] ) ) {
75 - $configArray[SeleniumSettings][browsers] = $configArray[browsers];
76 - unset ( $configArray[browsers] );
 74+ if ( isset( $configArray['browsers'] ) ) {
 75+ $configArray['SeleniumSettings']['browsers'] = $configArray['browsers'];
 76+ unset ( $configArray['browsers'] );
7777 }
7878
79 - if ( isset( $configArray[testSuite] ) ) {
80 - $configArray[SeleniumTests][testSuite] = $configArray[testSuite];
81 - unset ( $configArray[testSuite] );
 79+ if ( isset( $configArray['testSuite'] ) ) {
 80+ $configArray['SeleniumTests']['testSuite'] = $configArray['testSuite'];
 81+ unset ( $configArray['testSuite'] );
8282 }
8383
8484 return $configArray;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74750* handle PHP 5.2 ini files...mglaser23:52, 13 October 2010

Status & tagging log