r74960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74959‎ | r74960 | r74961 >
Date:19:43, 18 October 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed missing i++ from r74906
Modified paths:
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js
@@ -370,8 +370,8 @@
371371 },
372372
373373 // Get sub captions by language key:
374 - getSubCaptions: function( langKey, callback ){
375 - for( var i=0; i < this.textSources.length ) {
 374+ getSubCaptions: function( langKey, callback ){
 375+ for( var i=0; i < this.textSources.length; i++ ) {
376376 var source = this.textSources[ i ];
377377 if( source.srclang.toLowerCase() == langKey ) {
378378 var source = this.textSources[ i ];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74906Dont use object iterator loops on arrays. There are a few more for loops, of ...hartman18:13, 17 October 2010

Status & tagging log