r74953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74952‎ | r74953 | r74954 >
Date:17:42, 18 October 2010
Author:platonides
Status:ok
Tags:
Comment:
Double braces introduced in r74742 giving a fatal:
PHP Parse error: syntax error, unexpected $end in ./maintenance/purgeOldText.inc on line 63
Modified paths:
  • /trunk/phase3/maintenance/purgeOldText.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/purgeOldText.inc
@@ -29,7 +29,7 @@
3030 # Get "active" text records from the archive table
3131 echo( "Searching for active text records in archive table..." );
3232 $res = $dbw->query( "SELECT DISTINCT ar_text_id FROM $tbl_arc" );
33 - foreach ( $res as $row ) { {
 33+ foreach ( $res as $row ) {
3434 $cur[] = $row->ar_text_id;
3535 }
3636 echo( "done.\n" );
@@ -39,7 +39,7 @@
4040 $set = implode( ', ', $cur );
4141 $res = $dbw->query( "SELECT old_id FROM $tbl_txt WHERE old_id NOT IN ( $set )" );
4242 $old = array();
43 - foreach ( $res as $row ) { {
 43+ foreach ( $res as $row ) {
4444 $old[] = $row->old_id;
4545 }
4646 echo( "done.\n" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74742Assignment in loop conditions suck...reedy22:34, 13 October 2010

Status & tagging log