r74933 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74932‎ | r74933 | r74934 >
Date:22:39, 17 October 2010
Author:hartman
Status:ok
Tags:
Comment:
One more for loop issue.
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/mw.EmbedPlayer.js
@@ -1193,9 +1193,9 @@
11941194 */
11951195 hasStreamOfMIMEType: function( mimeType )
11961196 {
1197 - for ( source in this.sources )
 1197+ for ( var i = 0; i < this.sources.length; i++ )
11981198 {
1199 - if ( this.sources[source].getMIMEType() == mimeType ){
 1199+ if ( this.sources[i].getMIMEType() == mimeType ){
12001200 return true;
12011201 }
12021202 }

Status & tagging log