r74923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74922‎ | r74923 | r74924 >
Date:21:54, 17 October 2010
Author:hartman
Status:ok (Comments)
Tags:
Comment:
cleanup whitespace
Modified paths:
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.UploadInterface.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.UploadInterface.js
@@ -22,7 +22,7 @@
2323 } );
2424
2525 /**
26 - * Set the base uploadInterface
 26+ * Set the base uploadInterface
2727 */
2828 mw.UploadInterface = { };
2929
@@ -30,7 +30,7 @@
3131 * Upload Dialog Interface
3232 */
3333 mw.UploadDialogInterface = function( uploadHandler ) {
34 - // Set a reference the uploadHandler if provided
 34+ // Set a reference the uploadHandler if provided
3535 if( uploadHandler ) {
3636 this.uploadHandler = uploadHandler;
3737 }
@@ -151,11 +151,11 @@
152152
153153 /**
154154 * Update the progress bar to a given completion fraction (between 0 and 1)
155 - * NOTE: This progress bar is used for encoding AND for upload. The dialog title is set elsewhere
156 - *
157 - * @param {Float} progress Progress float
158 - * @param {Number} [loaded] optional Bytes loaded
159 - * @param {Number} [contentLength] optional Length of content
 155+ * NOTE: This progress bar is used for encoding AND for upload. The dialog title is set elsewhere
 156+ *
 157+ * @param {Float} progress Progress float
 158+ * @param {Number} [loaded] optional Bytes loaded
 159+ * @param {Number} [contentLength] optional Length of content
160160 */
161161 updateProgress: function( fraction, loaded, contentLength ) {
162162 var _this = this;
@@ -232,12 +232,12 @@
233233 if ( !buttons ) {
234234 // If no buttons are specified, add a close button
235235 buttons = {};
236 - buttons[ gM( 'mwe-ok' ) ] = function() {
 236+ buttons[ gM( 'mwe-ok' ) ] = function() {
237237 $j( this ).dialog( 'close' ).remove();
238238 };
239239 }
240240
241 - $j( '#upProgressDialog' ).dialog( 'option', 'title', title_txt );
 241+ $j( '#upProgressDialog' ).dialog( 'option', 'title', title_txt );
242242 if ( !msg ) {
243243 $j( '#upProgressDialog' ).loadingSpinner();
244244 } else {
@@ -357,7 +357,7 @@
358358 // If nothing above was able to set the error
359359 // set simple unknown-error
360360 if ( apiRes.upload && apiRes.upload.error ) {
361 - mw.log( ' apiRes.upload.error: ' + apiRes.upload.error );
 361+ mw.log( ' apiRes.upload.error: ' + apiRes.upload.error );
362362 _this.setPrompt(
363363 gM( 'mwe-uploaderror' ),
364364 gM( 'mwe-unknown-error' ) + '<br>',
@@ -438,7 +438,7 @@
439439
440440 /**
441441 * Send an upload action to the upload handler.
442 - * @param {Object} action
 442+ * @param {Object} action
443443 */
444444 sendUploadAction: function( action ) {
445445 this.uploadHandler.uploadHandlerAction( action );
@@ -513,7 +513,7 @@
514514 * init
515515 * @param {Function} callbackProxy Function that reciveds
516516 * all the method calls to be pass along as msgs to the
517 - * other domain via iframe proxy or eventually html5 sendMsg
 517+ * other domain via iframe proxy or eventually html5 sendMsg
518518 */
519519 init: function( callbackProxy ){
520520 var _this = this;
@@ -522,7 +522,7 @@
523523
524524 // Don't call update progress more than once every 3 seconds
525525 // Since it involves loading a cached iframe. Once we support html5
526 - // cross domain "sendMsg" then we can pass all updates
 526+ // cross domain "sendMsg" then we can pass all updates
527527 updateProgress: function( fraction ) {
528528 if( ( new Date() ).getTime() - this.lastProgressTime > 3000 ){
529529 this.lastProgressTime = ( new Date() ).getTime()
@@ -545,7 +545,7 @@
546546 this.callbackProxy( 'setLoading' );
547547 },
548548
549 - // Pass on the show api errror:
 549+ // Pass on the show api errror:
550550 showApiError: function ( apiRes ){
551551 this.callbackProxy( 'showApiError', apiRes );
552552 },

Comments

#Comment by Mdale (talk | contribs)   19:48, 18 October 2010

thanks for whitespace fixes... Note: we will be shifting code documentation to jsDOC style as mentioned in r69090#c10200

Status & tagging log