r74890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74889‎ | r74890 | r74891 >
Date:10:17, 17 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.7.1 - updated RELEASE-NOTES and did some cleanup
Modified paths:
  • /trunk/extensions/SemanticMaps/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/RELEASE-NOTES
@@ -10,8 +10,14 @@
1111 === Semantic Maps 0.7.1 ===
1212 (2010-1x-xx)
1313
14 -*
 14+==== New features ====
1515
 16+* Image layers for OpenLayers maps, defined via pages in the Layer namespace.
 17+
 18+==== Bug fixes ====
 19+
 20+* Support for images without namespace prefix in the statispoints parameter in map ask queries.
 21+
1622 === Semantic Maps 0.7 ===
1723 (2010-10-15)
1824
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -195,7 +195,7 @@
196196 $validator->validateParameters();
197197
198198 $fatalError = $validator->hasFatalError();
199 -
 199+
200200 if ( $fatalError === false ) {
201201 $this->zoomDefaulted = $validator->getParameter( 'zoom' )->wasSetToDefault();
202202 $this->setMapProperties( $validator->getParameterValues() );
@@ -291,16 +291,7 @@
292292 }
293293
294294 if ( $markerData['icon'] != '' ) {
295 - if ( strpos( $markerData['icon'], ':' ) === false ) {
296 - $markerData['icon'] = 'File:' . $markerData['icon'];
297 - }
298 -
299 - $title = Title::newFromText( $markerData['icon'] );
300 -
301 - if ( !is_null( $title ) && $title->exists() ) {
302 - $iconImagePage = new ImagePage( $title );
303 - $markerData['icon'] = $iconImagePage->getDisplayedFile()->getURL();
304 - }
 295+ $markerData['icon'] = MapsMapper::getImageUrl( $markerData['icon'] );
305296 }
306297
307298 // Temporary fix, will refactor away later

Status & tagging log