r74877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74876‎ | r74877 | r74878 >
Date:04:24, 17 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r74876
Modified paths:
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayersDispMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayersDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_ParamOLLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayersDispPoint.php
@@ -16,7 +16,7 @@
1717 public function addSpecificMapHTML( Parser $parser ) {
1818 global $wgLang;
1919
20 - $layerItems = $this->service->createLayersStringAndLoadDependencies( $this->layers[0] );
 20+ $this->service->addLayerDependencies( $this->layers[1] );
2121
2222 $mapName = $this->service->getMapId();
2323
@@ -37,7 +37,7 @@
3838 $this->centreLon,
3939 $this->centreLat,
4040 $this->zoom,
41 - [$layerItems],
 41+ {$this->layers[0]},
4242 [$this->controls],
4343 $this->markerJs,
4444 "$langCode"
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_ParamOLLayers.php
@@ -70,7 +70,7 @@
7171 $parameter->setValue( array(
7272 '[' . implode( ',', $layerDefs ) . ']',
7373 $this->getDependencies( $layerNames )
74 - ) );
 74+ ) );
7575 }
7676
7777 /**
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayersDispMap.php
@@ -16,7 +16,7 @@
1717 public function addSpecificMapHTML( Parser $parser ) {
1818 global $wgLang;
1919
20 - $layerItems = $this->service->addLayerDependencies( $this->layers[1] );
 20+ $this->service->addLayerDependencies( $this->layers[1] );
2121
2222 $mapName = $this->service->getMapId();
2323

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74876Changes for 0.7.1 - images as layers... it only took one and a half year :Djeroendedauw04:22, 17 October 2010

Status & tagging log