r74786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74785‎ | r74786 | r74787 >
Date:17:56, 14 October 2010
Author:pdhanda
Status:ok
Tags:
Comment:
Cleanup of SimpleSeleniumTestCase. Removed unnecessary include.
Modified paths:
  • /trunk/phase3/maintenance/tests/selenium/SimpleSeleniumConfig.php (modified) (history)
  • /trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTestCase.php (modified) (history)
  • /trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTestSuite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/selenium/SimpleSeleniumConfig.php
@@ -3,7 +3,7 @@
44
55 public static function getSettings(&$includeFiles, &$globalConfigs) {
66 $includes = array(
7 - 'skins/Chick.php'
 7+ //files that needed to be included would go here
88 );
99 $configs = array(
1010 'wgDefaultSkin' => 'chick'
Index: trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTestSuite.php
@@ -7,7 +7,6 @@
88 * $wgSeleniumTestConfigs['SimpleSeleniumTestSuite'] = 'SimpleSeleniumConfig::getSettings';
99 * OR
1010 * 2) Add the following to your Localsettings.php
11 - * require_once( "$IP/skins/Chick.php" );
1211 * $wgDefaultSkin = 'chick';
1312 */
1413 class SimpleSeleniumTestSuite extends SeleniumTestSuite
Index: trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTestCase.php
@@ -17,6 +17,10 @@
1818 $this->assertEquals( $correct, true );
1919 }
2020
 21+ /*
 22+ * All this test really does is verify that a global var was set.
 23+ * It depends on $wgDefaultSkin = 'chick'; being set
 24+ */
2125 public function testGlobalVariableForDefaultSkin() {
2226 $this->open( $this->getUrl() . '/index.php?&action=purge' );
2327 $bodyClass = $this->getAttribute( "//body/@class" );

Status & tagging log