r74776 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74775‎ | r74776 | r74777 >
Date:14:38, 14 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r74775
Modified paths:
  • /trunk/extensions/Maps/includes/parserHooks/Maps_DisplayMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/parserHooks/Maps_DisplayPoint.php (modified) (history)
  • /trunk/extensions/Maps/includes/parserHooks/Maps_Geocode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/parserHooks/Maps_DisplayPoint.php
@@ -140,6 +140,21 @@
141141 $mapClass = $service->getFeatureInstance( 'display_point' );
142142
143143 return $mapClass->getMapHtml( $parameters, $this->parser );
 144+ }
 145+
 146+ /**
 147+ * Returns the parser function otpions.
 148+ * @see ParserHook::getFunctionOptions
 149+ *
 150+ * @since 0.7
 151+ *
 152+ * @return array
 153+ */
 154+ protected function getFunctionOptions() {
 155+ return array(
 156+ 'noparse' => true,
 157+ 'isHTML' => true
 158+ );
144159 }
145160
146161 }
\ No newline at end of file
Index: trunk/extensions/Maps/includes/parserHooks/Maps_DisplayMap.php
@@ -104,6 +104,21 @@
105105 $mapClass = $service->getFeatureInstance( $this->getName() );
106106
107107 return $mapClass->getMapHtml( $parameters, $this->parser );
 108+ }
 109+
 110+ /**
 111+ * Returns the parser function otpions.
 112+ * @see ParserHook::getFunctionOptions
 113+ *
 114+ * @since 0.7
 115+ *
 116+ * @return array
 117+ */
 118+ protected function getFunctionOptions() {
 119+ return array(
 120+ 'noparse' => true,
 121+ 'isHTML' => true
 122+ );
108123 }
109124
110125 }
\ No newline at end of file
Index: trunk/extensions/Maps/includes/parserHooks/Maps_Geocode.php
@@ -120,18 +120,6 @@
121121 */
122122 protected function getDefaultParameters( $type ) {
123123 return array( 'location', 'geoservice', 'mappingservice' );
124 - }
125 -
126 - /**
127 - * Returns the parser function otpions.
128 - * @see ParserHook::getFunctionOptions
129 - *
130 - * @since 0.7
131 - *
132 - * @return array
133 - */
134 - protected function getFunctionOptions() {
135 - return array();
136124 }
137125
138126 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74775Follow up to r74772jeroendedauw14:38, 14 October 2010

Status & tagging log