r74747 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74746‎ | r74747 | r74748 >
Date:23:43, 13 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Fixup r74646

Remove unreachable return false;

Fix $tohis to $this
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/bootstrap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/bootstrap.php
@@ -44,12 +44,11 @@
4545
4646 function __call( $func, $args ) {
4747 if ( method_exists( $this->suite, $func ) ) {
48 - return call_user_func_array( array( $tohis->suite, $func ), $args);
 48+ return call_user_func_array( array( $this->suite, $func ), $args);
4949 } else {
5050 throw new MWException( "Called non-existant $func method on "
5151 . get_class( $this ) );
5252 }
53 - return false;
5453 }
5554 }
5655

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74646NOTE THAT THIS COMMIT REVEALS FAILING PARSER TESTS WHEN THEY ARE RUN IN PHPUn...mah22:50, 11 October 2010

Status & tagging log