r74741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74740‎ | r74741 | r74742 >
Date:22:02, 13 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Integrated r74740.
Modified paths:
  • /branches/uploadwizard/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: branches/uploadwizard/phase3/skins/common/wikibits.js
@@ -352,15 +352,16 @@
353353 // unhide portlet if it was hidden before
354354 root.className = root.className.replace( /(^| )emptyPortlet( |$)/, "$2" );
355355
356 - var span = document.createElement( 'span' );
357 - span.appendChild( document.createTextNode( text ) );
358 -
359356 var link = document.createElement( 'a' );
360 - link.appendChild( span );
 357+ link.appendChild( document.createTextNode( text ) );
361358 link.href = href;
362359
 360+ // Wrap in a span - make it work with vector tabs and has no effect on any other portlets
 361+ var span = document.createElement( 'span' );
 362+ span.appendChild( link );
 363+
363364 var item = document.createElement( 'li' );
364 - item.appendChild( link );
 365+ item.appendChild( span );
365366 if ( id ) {
366367 item.id = id;
367368 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74740Fixes bug in wikibits that causes addPortletLink to fail when adding tabs to ...tparscal21:58, 13 October 2010

Status & tagging log