r74723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74722‎ | r74723 | r74724 >
Date:18:31, 13 October 2010
Author:kaldari
Status:deferred
Tags:
Comment:
formatting changes
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/includes/countryCodes.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php
@@ -36,6 +36,8 @@
3737
3838 $form .= Xml::openElement( 'td', array( 'id' => 'donate', 'valign' => 'top' ) );
3939
 40+ $form .= Xml::tags( 'h2', array( 'id' => 'donate-head' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
 41+
4042 // provide a place at the top of the form for displaying general messages
4143 if ( $this->form_errors['general'] ) {
4244 $form .= Xml::openElement( 'div', array( 'id' => 'mw-payflow-general-error' ));
@@ -49,9 +51,6 @@
5052 $form .= Xml::closeElement( 'div' ); // close div#mw-payflow-general-error
5153 }
5254
53 - // open form
54 - $form .= Xml::openElement( 'div', array( 'id' => 'mw-creditcard-form' ) );
55 -
5655 // Xml::element seems to convert html to htmlentities
5756 $form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
5857 $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => '', 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );
@@ -69,7 +68,6 @@
7069 protected function generateBillingContainer() {
7170 $form = '';
7271 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' ));
73 - $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header','id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
7472 $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
7573 $form .= $this->generateBillingFields();
7674 $form .= Xml::closeElement( 'table' ); // close table#payflow-table-donor
@@ -145,7 +143,7 @@
146144
147145 $form .= Xml::closeElement( 'form' ); // close form 'payment'
148146 $form .= $this->generateDonationFooter();
149 - $form .= Xml::closeElement( 'td' ); //close div#mw-creditcard
 147+ $form .= Xml::closeElement( 'td' );
150148 $form .= Xml::closeElement( 'tr' );
151149 $form .= Xml::closeElement( 'table' );
152150 return $form;
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter.css
@@ -45,6 +45,10 @@
4646 padding-top: .5em;
4747 display: block;
4848 }
 49+#payflowpro_gateway-donate-addl-info {
 50+ margin-top:3em !important;
 51+ margin-bottom:1em !important;
 52+}
4953
5054 #appeal {
5155 background-color:#F3F3F3;
@@ -68,7 +72,7 @@
6973 background-color:#A9D9A3;
7074 border:1px solid #5EAC58;
7175 padding:16px 24px 24px;
72 - width:350px;
 76+ width:400px;
7377 }
7478 #donate-head {
7579 border-color:#5EAC58;
Index: trunk/extensions/DonationInterface/payflowpro_gateway/includes/countryCodes.inc
@@ -203,7 +203,7 @@
204204 '090' => 'Solomon Islands',
205205 '706' => 'Somalia',
206206 '710' => 'South Africa',
207 - '239' => 'South Georgia and the South Sandwich Islands',
 207+ //'239' => 'South Georgia and the South Sandwich Islands',
208208 '724' => 'Spain',
209209 '144' => 'Sri Lanka',
210210 '654' => 'Saint Helena',

Status & tagging log