r74716 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74715‎ | r74716 | r74717 >
Date:06:54, 13 October 2010
Author:dale
Status:deferred
Tags:
Comment:
* fixed jquery.ui.core override of older versions of jquery.ui core
* other minor cleanup
Modified paths:
  • /branches/MwEmbedStandAlone/libraries/jquery/jquery.ui/ui/jquery.ui.core.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/ClipEdit/mw.ClipEdit.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/MiroSubs/mw.MiroSubsConfig.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/MiroSubs/mw.MiroSubsConfig.js
@@ -1,5 +1,5 @@
22
3 -// include all our module messages
 3+// include all module messages
44 mw.includeAllModuleMessages();
55
66 /**
Index: branches/MwEmbedStandAlone/modules/AddMedia/mw.RemoteSearchDriver.js
@@ -2342,8 +2342,8 @@
23432343
23442344 // Add libraries resizable and hoverIntent to support video edit tools
23452345 var librarySet = [
2346 - 'mw.ClipEdit',
2347 - 'mw.style.ClipEdit',
 2346+ 'mw.ClipEdit',
 2347+ 'mw.style.ClipEdit',
23482348 '$j.ui.resizable'
23492349 ];
23502350 mw.load( librarySet, function() {
Index: branches/MwEmbedStandAlone/modules/ClipEdit/mw.ClipEdit.js
@@ -2,37 +2,8 @@
33 * mw.ClipEdit handles the edit interfaces for images and video
44 */
55
6 -// set gMsg object:
7 -mw.addMessages( {
8 - "mwe-clipedit-crop" : "Crop image",
9 - "mwe-clipedit-apply_crop" : "Apply crop to image",
10 - "mwe-clipedit-reset_crop" : "Reset crop",
11 - "mwe-clipedit-insert_image_page" : "Insert into page",
12 - "mwe-clipedit-insert_into_sequence" : "Insert into sequence",
13 - "mwe-clipedit-preview_insert" : "Preview insert",
14 - "mwe-clipedit-cancel_image_insert" : "Cancel insert",
15 - "mwe-clipedit-sc_attributes" : "Clip detail edit",
16 - "mwe-clipedit-sc_inoutpoints" : "Set in-out points",
17 - "mwe-clipedit-sc_overlays" : "Overlays",
18 - "mwe-clipedit-sc_audio" : "Audio control",
19 - "mwe-clipedit-sc_duration" : "Duration",
20 - "mwe-clipedit-template_properties" : "Template properties",
21 - "mwe-clipedit-custom_title" : "Custom title",
22 - "mwe-clipedit-edit_properties" : "Edit properties",
23 - "mwe-clipedit-other_properties" : "Other properties",
24 - "mwe-clipedit-resource_page" : "Resource page:",
25 - "mwe-clipedit-set_in_out_points" : "Set in-out points",
26 - "mwe-clipedit-start_time" : "Start time",
27 - "mwe-clipedit-end_time" : "End time",
28 - "mwe-clipedit-preview_inout" : "Preview in-out points",
29 - "mwe-clipedit-edit-tools" : "Edit tools",
30 - "mwe-clipedit-inline-description" : "Caption",
31 - "mwe-clipedit-edit-video-tools" : "Edit video tools:",
32 - "mwe-clipedit-duration" : "Duration:",
33 - "mwe-clipedit-layout" : "Layout",
34 - "mwe-clipedit-layout_right" : "Right side image layout",
35 - "mwe-clipedit-layout_left" : "Left side image layout"
36 -} );
 6+// include all module messages
 7+mw.includeAllModuleMessages();
378
389 /**
3910 * The default clipEdit values
Index: branches/MwEmbedStandAlone/libraries/jquery/jquery.ui/ui/jquery.ui.core.js
@@ -13,7 +13,7 @@
1414 // this is only a problem because we proxy existing functions
1515 // and we don't want to double proxy them
1616 $.ui = $.ui || {};
17 -if ( $.ui.version ) {
 17+if ( $.ui.version == "1.8.4") {
1818 return;
1919 }
2020
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -80,6 +80,7 @@
8181
8282
8383
 84+
8485 // Use wikibits onLoad hook: ( since we don't have js2 / mw object loaded )
8586 if( window.jQuery ){
8687 jQuery( document ).ready( doPageSpecificRewrite );
@@ -113,11 +114,16 @@
114115 '$j.ui',
115116 '$j.widget',
116117 '$j.ui.mouse',
117 - '$j.ui.sortable'
 118+ '$j.ui.position',
 119+ '$j.ui.progressbar',
 120+ '$j.ui.dialog',
 121+ '$j.ui.draggable',
 122+ '$j.ui.sortable',
 123+ '$j.ui.datepicker'
118124 ], function() {
119125 mw.load( mwEmbedHostPath + '/remotes/AddMediaWizardEditPage.js?' + mwGetReqArgs() );
120126 } );
121 - },100);
 127+ },200);
122128 return ;
123129 }
124130 }
@@ -641,7 +647,7 @@
642648 importScriptURI( mwEmbedHostPath + '/libraries/jquery/jquery-1.4.2.js?' + mwGetReqArgs() );
643649 }
644650 setTimeout( waitForJQueryUpgrade, 5);
645 - } else {
 651+ } else {
646652 // load mwEmbed js
647653 importScriptURI( mwEmbedHostPath + '/mwEmbed.js?' + mwGetReqArgs() );
648654 waitMwEmbedReady( function(){

Status & tagging log