r74695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74694‎ | r74695 | r74696 >
Date:22:48, 12 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove unused array index, add a couple of braces
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -163,7 +163,7 @@
164164 */
165165 function findFiles( $items ) {
166166 $result = array();
167 - foreach ( $items as $index => $item ) {
 167+ foreach ( $items as $item ) {
168168 if ( is_array( $item ) ) {
169169 $title = $item['title'];
170170 $options = $item;
@@ -173,8 +173,9 @@
174174 $options = array();
175175 }
176176 $file = $this->findFile( $title, $options );
177 - if ( $file )
 177+ if ( $file ) {
178178 $result[$file->getTitle()->getDBkey()] = $file;
 179+ }
179180 }
180181 return $result;
181182 }

Status & tagging log