r74690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74689‎ | r74690 | r74691 >
Date:20:57, 12 October 2010
Author:neilk
Status:ok
Tags:
Comment:
check is unnecessary; fails on fresh wiki installs that don't have an image temp dir yet
Modified paths:
  • /branches/uploadwizard/phase3/includes/upload/SessionStash.php (modified) (history)

Diff [purge]

Index: branches/uploadwizard/phase3/includes/upload/SessionStash.php
@@ -36,14 +36,10 @@
3737 $repo = RepoGroup::singleton()->getLocalRepo();
3838 }
3939
40 - // sanity check repo. If we want to mock the repo later this should be modified.
41 - if ( ! is_dir( $repo->getZonePath( 'temp' ) ) ) {
42 - throw new SessionStashNotAvailableException();
43 - }
4440 $this->repo = $repo;
4541
4642 if ( ! isset( $_SESSION ) ) {
47 - throw new SessionStashNotAvailableException();
 43+ throw new SessionStashNotAvailableException( 'no session var' );
4844 }
4945
5046 if ( !isset( $_SESSION[UploadBase::SESSION_KEYNAME] ) ) {

Status & tagging log