r74614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74613‎ | r74614 | r74615 >
Date:08:32, 11 October 2010
Author:catrope
Status:ok
Tags:
Comment:
(bug 25474) Fix wrong parameters in updateModule() call. r74525 tried to fix this, but missed the point. Patch by Borislav Manolov
Modified paths:
  • /trunk/phase3/includes/MessageBlobStore.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MessageBlobStore.php
@@ -330,7 +330,7 @@
331331 // older than $wgCacheEpoch
332332 if ( array_keys( FormatJson::decode( $row->mr_blob, true ) ) !== $module->getMessages() ||
333333 wfTimestamp( TS_MW, $row->mr_timestamp ) <= $wgCacheEpoch ) {
334 - $retval[$row->mr_resource] = self::updateModule( $module, $lang );
 334+ $retval[$row->mr_resource] = self::updateModule( $row->mr_resource, $module, $lang );
335335 } else {
336336 $retval[$row->mr_resource] = $row->mr_blob;
337337 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74525* Improved on r73971 by removing the $name parameter from MessageBlobStore::g...tparscal18:42, 8 October 2010

Status & tagging log