r74597 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74596‎ | r74597 | r74598 >
Date:15:15, 10 October 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Use of __construct() instead of ClassName()
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QueryParser.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QueryPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_QueryResult.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QueryPrinter.php
@@ -86,7 +86,7 @@
8787 * Constructor. The parameter $format is a format string
8888 * that may influence the processing details.
8989 */
90 - public function SMWResultPrinter( $format, $inline ) {
 90+ public function __constuct( $format, $inline ) {
9191 global $smwgQDefaultLinking;
9292 $this->mFormat = $format;
9393 $this->mInline = $inline;
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QueryParser.php
@@ -23,7 +23,7 @@
2424 protected $m_conceptprefix; // cache label of concept namespace . ':'
2525 protected $m_queryfeatures; // query features to be supported, format similar to $smwgQFeatures
2626
27 - public function SMWQueryParser( $queryfeatures = false ) {
 27+ public function __construct( $queryfeatures = false ) {
2828 global $wgContLang, $smwgQFeatures;
2929 $this->m_categoryprefix = $wgContLang->getNsText( NS_CATEGORY ) . ':';
3030 $this->m_conceptprefix = $wgContLang->getNsText( SMW_NS_CONCEPT ) . ':';
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_QueryResult.php
@@ -255,7 +255,7 @@
256256 * @param SMWPrintRequest $printRequest
257257 * @param SMWStore $store
258258 */
259 - public function SMWResultArray( SMWWikiPageValue $resultPage, SMWPrintRequest $printRequest, SMWStore $store ) {
 259+ public function __construct( SMWWikiPageValue $resultPage, SMWPrintRequest $printRequest, SMWStore $store ) {
260260 $this->mResult = $resultPage;
261261 $this->mPrintRequest = $printRequest;
262262 $this->mStore = $store;

Status & tagging log