r74595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74594‎ | r74595 | r74596 >
Date:14:39, 10 October 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r74135 removing the globals, too.
htmlescape the global.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -815,7 +815,7 @@
816816 }
817817
818818 function setup_database() {
819 - global $wgVersion, $wgDBport, $wgDBuser;
 819+ global $wgDBuser;
820820
821821 // Make sure that we can write to the correct schema
822822 $ctest = "mediawiki_test_table";
@@ -825,7 +825,7 @@
826826 $SQL = "CREATE TABLE $ctest (a int)";
827827 $res = $this->doQuery( $SQL );
828828 if ( !$res ) {
829 - print "<b>FAILED</b>. Make sure that the user \"$wgDBuser\" can write to the database</li>\n";
 829+ print "<b>FAILED</b>. Make sure that the user " . htmlspecialchars( $wgDBuser ) . " can write to the database</li>\n";
830830 dieout( "</ul>" );
831831 }
832832 $this->doQuery( "DROP TABLE $ctest" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74135Fix for r74134: copy-paste errorialex08:30, 2 October 2010

Status & tagging log