r74573 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74572‎ | r74573 | r74574 >
Date:00:34, 10 October 2010
Author:bawolff
Status:deferred
Tags:
Comment:
Follow-up to r74571. Per Nickrabbit, my spelling is horrible.

No behavioural changes.
(I'm sure Amgine also has some specific things to say on the subject of my spelling.)
Modified paths:
  • /branches/img_metadata/phase3/includes/media/Bitmap.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/BitmapMetadataHandler.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/Exif.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/FormatMetadata.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/IPTC.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/JpegMetadataExtractor.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/XMP.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/XMPInfo.php (modified) (history)
  • /branches/img_metadata/phase3/includes/media/XMPValidate.php (modified) (history)

Diff [purge]

Index: branches/img_metadata/phase3/includes/media/FormatMetadata.php
@@ -74,7 +74,7 @@
7575 $type = $tags[$tag]['_type'];
7676 unset( $vals['_type'] );
7777 } else {
78 - $type = 'ul'; // default unorcdered list.
 78+ $type = 'ul'; // default unordered list.
7979 }
8080
8181 //This is done differently as the tag is an array.
@@ -444,7 +444,7 @@
445445 }
446446 break;
447447
448 - //The GPS...Ref values are kept for compatability, probably won't be reached.
 448+ //The GPS...Ref values are kept for compatibility, probably won't be reached.
449449 case 'GPSLatitudeRef':
450450 case 'GPSDestLatitudeRef':
451451 switch( $val ) {
@@ -760,7 +760,7 @@
761761 * @param $vals Array array of values
762762 * @param $type Type of array (either lang, ul, ol).
763763 * lang = language assoc array with keys being the lang code
764 - * ul = unorded list, ol = ordered list
 764+ * ul = unordered list, ol = ordered list
765765 * type can also come from the '_type' member of $vals.
766766 * @return String single value (in wiki-syntax).
767767 */
@@ -789,7 +789,7 @@
790790 case 'lang':
791791 global $wgContLang;
792792 // Display default, followed by ContLang,
793 - // followed by the rest in no paticular
 793+ // followed by the rest in no particular
794794 // order.
795795
796796 // Todo: hide some items if really long list.
@@ -1075,7 +1075,7 @@
10761076 // Note: We run this through htmlspecialchars
10771077 // partially to be consistent, and partially
10781078 // because people often insert >, etc into
1079 - // the metadata which should not be interperted
 1079+ // the metadata which should not be interpreted
10801080 // but we still want to auto-link urls.
10811081 foreach( $vals as &$val ) {
10821082 $val = htmlspecialchars( $val );
@@ -1154,7 +1154,7 @@
11551155 /** For compatability with old FormatExif class
11561156 * which some extensions use.
11571157 *
1158 - *@deprected
 1158+ *@deprecated
11591159 *
11601160 **/
11611161 class FormatExif {
Index: branches/img_metadata/phase3/includes/media/Exif.php
@@ -99,7 +99,7 @@
100100 * @fixme the following are broke:
101101 * SubjectArea. Need to test the more obscure tags.
102102 *
103 - * DigitalZoomRatio = 0/0 is rejected. need to determine if thats valid.
 103+ * DigitalZoomRatio = 0/0 is rejected. need to determine if that's valid.
104104 * possibly should treat 0/0 = 0. need to read exif spec on that.
105105 */
106106 function __construct( $file ) {
@@ -226,7 +226,7 @@
227227 'Saturation' => Exif::SHORT, # Saturation #p50
228228 'Sharpness' => Exif::SHORT, # Sharpness #p50
229229 'DeviceSettingDescription' => Exif::IGNORE,
230 - # Desice settings description. This could maybe be supported. Need to find an
 230+ # Device settings description. This could maybe be supported. Need to find an
231231 # example file that uses this to see if it has stuff of interest in it.
232232 'SubjectDistanceRange' => Exif::SHORT, # Subject distance range #p51
233233
@@ -325,7 +325,7 @@
326326 /**
327327 * Collapse some fields together.
328328 * This converts some fields from exif form, to a more friendly form.
329 - * For example GPS lattitude to a single number.
 329+ * For example GPS latitude to a single number.
330330 *
331331 * The rationale behind this is that we're storing data, not presenting to the user
332332 * For example a longitude is a single number describing how far away you are from
@@ -429,7 +429,7 @@
430430 break;
431431 }
432432 // This could possibly check to see if iconv is really installed
433 - // or if we're using the compatability wraper in globalFunctions.php
 433+ // or if we're using the compatibility wrapper in globalFunctions.php
434434 if ($charset) {
435435 $val = iconv($charset, 'UTF-8//IGNORE', $val);
436436 } else {
Index: branches/img_metadata/phase3/includes/media/IPTC.php
@@ -10,12 +10,12 @@
1111 * form that can be handled by mediawiki. Generally called from
1212 * BitmapMetadataHandler::doApp13.
1313 *
14 - * At the moment this is more of an outline, and is definitly
 14+ * At the moment this is more of an outline, and is definitely
1515 * not complete.
1616 * @todo finish for other iptc values
1717 * @see http://www.iptc.org/std/IIM/4.1/specification/IIMV4.1.pdf
1818 *
19 - * @param String $data app13 block from jpeg containg iptc/iim data
 19+ * @param String $data app13 block from jpeg containing iptc/iim data
2020 * @return Array iptc metadata array
2121 */
2222 static function parse( $rawData ) {
@@ -55,7 +55,7 @@
5656 * like how exif does it with
5757 * Title, person. Not sure if this is best
5858 * approach since we no longer have the two fields
59 - * seperate. each byline title entry corresponds to a
 59+ * separate. each byline title entry corresponds to a
6060 * specific byline. */
6161
6262 $bylines = self::convIPTC( $val, $c );
@@ -113,10 +113,10 @@
114114 case '2#007': /* edit status (lead, correction, etc) */
115115 $data['EditStatus'] = self::convIPTC( $val, $c );
116116 break;
117 - case '2#015': /* category. deprected. max 3 letters in theory, often more */
 117+ case '2#015': /* category. deprecated. max 3 letters in theory, often more */
118118 $data['iimCategory'] = self::convIPTC( $val, $c );
119119 break;
120 - case '2#020': /* category. deprected. */
 120+ case '2#020': /* category. deprecated. */
121121 $data['iimSupplementalCategory'] = self::convIPTC( $val, $c );
122122 break;
123123 case '2#010': /*urgency (1-8. 1 most, 5 normal, 8 low priority)*/
@@ -134,7 +134,7 @@
135135 $data['LocationDestCode'] = self::convIPTC( $val, $c );
136136 break;
137137 case '2#027':
138 - /* Content location name. Full prinatable name
 138+ /* Content location name. Full printable name
139139 * of location of photo. */
140140 $data['LocationDest'] = self::convIPTC( $val, $c );
141141 break;
@@ -179,7 +179,7 @@
180180 case '2#103':
181181 /* original transmission ref.
182182 * "A code representing the location of original transmission ac-
183 - * cording to practices of the provider."
 183+ * cording to practises of the provider."
184184 */
185185 $data['OriginalTransmissionRef'] = self::convIPTC( $val, $c );
186186 break;
@@ -341,7 +341,7 @@
342342 //something wrong.
343343 // Note, this rejects some valid dates according to iptc spec
344344 // for example: the date 00000400 means the photo was taken in
345 - // april, but the year and day is unknown. We don't process these
 345+ // April, but the year and day is unknown. We don't process these
346346 // types of incomplete dates atm.
347347 wfDebugLog( 'iptc', "IPTC: invalid time ( $time ) or date ( $date )");
348348 return null;
@@ -423,15 +423,15 @@
424424 */
425425 static function getCharset($tag) {
426426
427 - //Acording to iim standard, charset is defined by the tag 1:90.
 427+ //According to iim standard, charset is defined by the tag 1:90.
428428 //in which there are iso 2022 escape sequences to specify the character set.
429 - //the iim standard seems to encourage that all neccesary escape sequences are
 429+ //the iim standard seems to encourage that all necessary escape sequences are
430430 //in the 1:90 tag, but says it doesn't have to be.
431431
432 - //This is in need of more testing probably. This is definitly not complete.
 432+ //This is in need of more testing probably. This is definitely not complete.
433433 //however reading the docs of some other iptc software, it appears that most iptc software
434434 //only recognizes utf-8. If 1:90 tag is not present content is
435 - // usually ascii or iso-8859-1 (and sometimes utf-8), but no garuntees.
 435+ // usually ascii or iso-8859-1 (and sometimes utf-8), but no guarantee.
436436
437437 //This also won't work if there are more than one escape sequence in the 1:90 tag
438438 //or if something is put in the G2, or G3 charsets, etc. It will only reliably recognize utf-8.
@@ -539,7 +539,7 @@
540540 $c = 'CSN_369103';
541541 break;
542542 default:
543 - wfDebugLog('iptc', __METHOD__ . 'Unkown charset in iptc 1:90: ' . bin2hex( $tag ) );
 543+ wfDebugLog('iptc', __METHOD__ . 'Unknown charset in iptc 1:90: ' . bin2hex( $tag ) );
544544 //at this point just give up and refuse to parse iptc?
545545 $c = false;
546546 }
Index: branches/img_metadata/phase3/includes/media/XMP.php
@@ -1,5 +1,5 @@
22 <?php
3 -/** Class for reading xmp data containing properties relevent to
 3+/** Class for reading xmp data containing properties relevant to
44 * images, and spitting out an array that FormatExif accepts.
55 *
66 * It should be noted this is not done yet
@@ -40,7 +40,7 @@
4141 /*
4242 * These are various mode constants.
4343 * they are used to figure out what to do
44 - * with an element when its encoutered.
 44+ * with an element when its encountered.
4545 *
4646 * For example, MODE_IGNORE is used when processing
4747 * a property we're not interested in. So if a new
@@ -56,7 +56,7 @@
5757 // $items array to denote what type of property the item is.
5858 const MODE_SIMPLE = 10;
5959 const MODE_STRUCT = 11; // structure (associative array)
60 - const MODE_SEQ = 12; // orderd list
 60+ const MODE_SEQ = 12; // ordered list
6161 const MODE_BAG = 13; // unordered list
6262 const MODE_LANG = 14;
6363 const MODE_ALT = 15; // non-language alt. Currently not implemented, and not needed atm.
@@ -67,7 +67,7 @@
6868
6969 /** Constructor.
7070 *
71 - * Primary job is to intialize the XMLParser
 71+ * Primary job is to initialize the XMLParser
7272 */
7373 function __construct() {
7474
@@ -107,7 +107,7 @@
108108
109109 /** Destroy the xml parser
110110 *
111 - * not sure if this is actualy needed.
 111+ * not sure if this is actually needed.
112112 */
113113 function __destruct() {
114114 // not sure if this is needed.
@@ -208,7 +208,7 @@
209209 }
210210
211211 } else {
212 - // standard specificly says, if no bom assume utf-8
 212+ // standard specifically says, if no bom assume utf-8
213213 $this->charset = 'UTF-8';
214214 }
215215 }
@@ -241,7 +241,7 @@
242242 * @todo In serious need of testing
243243 * @see http://www.adobe.ge/devnet/xmp/pdfs/XMPSpecificationPart3.pdf XMP spec part 3 page 20
244244 * @param String $content XMPExtended block minus the namespace signature
245 - * @return Boolean If it succeded.
 245+ * @return Boolean If it succeeded.
246246 */
247247 public function parseExtended( $content ) {
248248 // FIXME: This is untested. Hard to find example files
@@ -492,7 +492,7 @@
493493
494494 if ( $elm === self::NS_RDF . ' type' ) {
495495 // these aren't really supported properly yet.
496 - wfDebugLog( 'XMP', __METHOD__ . ' encoutered <rdf:type>' );
 496+ wfDebugLog( 'XMP', __METHOD__ . ' encountered <rdf:type>' );
497497 }
498498
499499 if ( strpos( $elm, ' ' ) === false ) {
@@ -548,7 +548,7 @@
549549
550550 /** Hit an opening element while in MODE_IGNORE
551551 *
552 - * Mostly ignores, unless we encouter the element that we are ignoring.
 552+ * Mostly ignores, unless we encounter the element that we are ignoring.
553553 *
554554 * @param $elm String namespace . ' ' . tag name
555555 */
@@ -562,7 +562,7 @@
563563 * this should always be <rdf:Bag>
564564 *
565565 * @param $elm String namespace . ' ' . tag
566 - * @throws MWException if we have an element thats not <rdf:Bag>
 566+ * @throws MWException if we have an element that's not <rdf:Bag>
567567 */
568568 private function startElementModeBag( $elm ) {
569569 if ( $elm === self::NS_RDF . ' Bag' ) {
@@ -576,7 +576,7 @@
577577 * this should always be <rdf:Seq>
578578 *
579579 * @param $elm String namespace . ' ' . tag
580 - * @throws MWException if we have an element thats not <rdf:Seq>
 580+ * @throws MWException if we have an element that's not <rdf:Seq>
581581 */
582582 private function startElementModeSeq( $elm ) {
583583 if ( $elm === self::NS_RDF . ' Seq' ) {
@@ -590,7 +590,7 @@
591591 * this should always be <rdf:Alt>
592592 *
593593 * @param $elm String namespace . ' ' . tag
594 - * @throws MWException if we have an element thats not <rdf:Alt>
 594+ * @throws MWException if we have an element that's not <rdf:Alt>
595595 */
596596 private function startElementModeLang( $elm ) {
597597 if ( $elm === self::NS_RDF . ' Alt' ) {
@@ -605,7 +605,7 @@
606606 * already opened has a child element. Could happen for a
607607 * qualified element.
608608 *
609 - * @param $elm String namespace and tag names seperated by space.
 609+ * @param $elm String namespace and tag names separated by space.
610610 */
611611 private function startElementModeSimple( $elm, $attribs ) {
612612 if ( $elm === self::NS_RDF . ' Description' ) {
@@ -623,7 +623,7 @@
624624
625625 } else {
626626 // something else we don't recognize, like a qualifier maybe.
627 - wfDebugLog( 'XMP', __METHOD__ . " Encoutered element <$elm> where only expecting character data as value of " . $this->curItem[0] );
 627+ wfDebugLog( 'XMP', __METHOD__ . " Encountered element <$elm> where only expecting character data as value of " . $this->curItem[0] );
628628 array_unshift( $this->mode, self::MODE_IGNORE );
629629 array_unshift( $this->curItem, $elm );
630630
@@ -666,7 +666,7 @@
667667 // a child of a struct), then something weird is
668668 // happening, so ignore this element and its children.
669669
670 - wfDebugLog( 'XMP', "Encoutered <$ns:$tag> outside"
 670+ wfDebugLog( 'XMP', "Encountered <$ns:$tag> outside"
671671 . " of its expected parent. Ignoring." );
672672
673673 array_unshift( $this->mode, self::MODE_IGNORE );
@@ -809,7 +809,7 @@
810810 //
811811 // also it seems as if exiv2 and exiftool do not support
812812 // this either (That or I misunderstand the standard)
813 - wfDebugLog( 'XMP', __METHOD__ . ' Encoutered <rdf:type> which isn\'t currently supported' );
 813+ wfDebugLog( 'XMP', __METHOD__ . ' Encountered <rdf:type> which isn\'t currently supported' );
814814 }
815815
816816 if ( strpos( $elm, ' ' ) === false ) {
@@ -880,14 +880,14 @@
881881 && $val === 'Resource'
882882 && $this->mode[0] === self::MODE_SIMPLE )
883883 {
884 - // this is equivelent to having an inner rdf:Description
 884+ // this is equivalent to having an inner rdf:Description
885885 $this->mode[0] = self::MODE_QDESC;
886886 }
887887
888888 if ( strpos( $name, ' ' ) === false ) {
889889 // This shouldn't happen, but so far some old software forgets namespace
890890 // on rdf:about.
891 - wfDebugLog( 'XMP', __METHOD__ . ' Encoutered non-namespaced attribute: '
 891+ wfDebugLog( 'XMP', __METHOD__ . ' Encountered non-namespaced attribute: '
892892 . " $name=\"$val\". Skipping. " );
893893 continue;
894894 }
@@ -928,8 +928,8 @@
929929
930930 if ( is_callable( $validate ) ) {
931931 call_user_func_array( $validate, array( $info, &$val, true ) );
932 - // the resoning behind using &$val instead of using the return value
933 - // is to be consistant between here and validating structures.
 932+ // the reasoning behind using &$val instead of using the return value
 933+ // is to be consistent between here and validating structures.
934934 if ( is_null( $val ) ) {
935935 wfDebugLog( 'XMP', __METHOD__ . " <$ns:$tag> failed validation." );
936936 return;
Index: branches/img_metadata/phase3/includes/media/BitmapMetadataHandler.php
@@ -15,7 +15,7 @@
1616 20 => Array( 'other' ),
1717 40 => Array( 'native' ),
1818 60 => Array( 'iptc-good-hash', 'iptc-no-hash' ),
19 - 70 => Array( 'xmp-deprected' ),
 19+ 70 => Array( 'xmp-deprecated' ),
2020 80 => Array( 'xmp-general' ),
2121 90 => Array( 'xmp-exif' ),
2222 100 => Array( 'iptc-bad-hash' ),
Index: branches/img_metadata/phase3/includes/media/Bitmap.php
@@ -350,7 +350,7 @@
351351 * all that similar and usually have different
352352 * metadata needs.
353353 *
354 - * @deprected
 354+ * @deprecated
355355 */
356356 function getMetadata( $image, $filename ) {
357357 wfDeprected( __METHOD__ );
Index: branches/img_metadata/phase3/includes/media/XMPValidate.php
@@ -3,7 +3,7 @@
44 * This contains some static methods for
55 * validating XMP properties. See XMPInfo and XMPReader classes.
66 *
7 -* Each of these functions take the stame parameters
 7+* Each of these functions take the same parameters
88 * * an info array which is a subset of the XMPInfo::items array
99 * * A value (passed as reference) to validate. This can be either a
1010 * simple value or an array
@@ -159,7 +159,7 @@
160160 && isset( $val['RedEyeMode'] )
161161 && isset( $val['Return'] )
162162 ) ) {
163 - wfDebugLog( 'XMP', __METHOD__ . " Flash structure did not have all the required compoenents" );
 163+ wfDebugLog( 'XMP', __METHOD__ . " Flash structure did not have all the required components" );
164164 $val = null;
165165 } else {
166166 $val = ( "\0" | ( $val['Fired'] === 'True' )
@@ -215,7 +215,7 @@
216216 $val = null;
217217 } else {
218218 /*
219 - * $res is formated as follows:
 219+ * $res is formatted as follows:
220220 * 0 -> full date.
221221 * 1 -> year, 2-> month, 3-> day, 4-> hour, 5-> minute, 6->second
222222 * 7-> Timezone specifier (Z or something like +12:30 )
@@ -231,7 +231,7 @@
232232 return;
233233 }
234234 //if hour is set, so is minute or regex above will fail.
235 - //Extra check for empty string neccesary due to TZ but no second case.
 235+ //Extra check for empty string necessary due to TZ but no second case.
236236 $res[6] = isset( $res[6] ) && $res[6] != '' ? $res[6] : '00';
237237
238238 if ( !isset( $res[7] ) || $res[7] === 'Z' || $res[1] >= '2038' || $res[1] < '1902' ) {
Index: branches/img_metadata/phase3/includes/media/XMPInfo.php
@@ -25,11 +25,11 @@
2626 * tag, including:
2727 * * map_group - what group (used for precedence during conflicts)
2828 * * mode - What type of item (self::MODE_SIMPLE usually, see above for all values)
29 - * * validate - method to validate input. Could also post-process the input. A string value is assumed to be a static mthod of XMPValidate. Can also take a array( 'className', 'methodName' ).
 29+ * * validate - method to validate input. Could also post-process the input. A string value is assumed to be a static method of XMPValidate. Can also take a array( 'className', 'methodName' ).
3030 * * choices - array of potential values (format of 'value' => true ). Only used with validateClosed
3131 * * rangeLow and rangeHigh - alternative to choices for numeric ranges. Again for validateClosed only.
3232 * * children - for MODE_STRUCT items, allowed children.
33 - * * structPart - Indicates that this element can only appear as a memeber of a structure.
 33+ * * structPart - Indicates that this element can only appear as a member of a structure.
3434 *
3535 * currently this just has a bunch of exif values as this class is only half-done
3636 */
@@ -616,7 +616,7 @@
617617 ),
618618 'creator' => array(
619619 'map_group' => 'general',
620 - 'map_name' => 'Artist', //map with exif Artist, iptc bylin (2:80)
 620+ 'map_name' => 'Artist', //map with exif Artist, iptc byline (2:80)
621621 'mode' => XMPReader::MODE_SEQ,
622622 ),
623623 'date' => array(
@@ -630,7 +630,7 @@
631631 ),
632632 /* Do not extract dc:format, as we've got better ways to determine mimetype */
633633 'identifier' => array(
634 - 'map_group' => 'deprected',
 634+ 'map_group' => 'deprecated',
635635 'map_name' => 'Identifier',
636636 'mode' => XMPReader::MODE_SIMPLE,
637637 ),
@@ -705,7 +705,7 @@
706706 'MetadataDate' => array(
707707 'map_group' => 'general',
708708 'mode' => XMPReader::MODE_SIMPLE,
709 - // map_name to be consistant with other date names.
 709+ // map_name to be consistent with other date names.
710710 'map_name' => 'DateTimeMetadata',
711711 'validate' => 'validateDate',
712712 ),
@@ -791,29 +791,29 @@
792792 ),
793793 ),
794794 /* Note, in iptc schemas, the legacy properties are denoted
795 - * as deprected, since other properties should used instead,
796 - * and properties marked as deprected in the standard are
 795+ * as deprecated, since other properties should used instead,
 796+ * and properties marked as deprecated in the standard are
797797 * are marked as general here as they don't have replacements
798798 */
799799 'http://ns.adobe.com/photoshop/1.0/' => array(
800800 'City' => array(
801 - 'map_group' => 'deprected',
 801+ 'map_group' => 'deprecated',
802802 'mode' => XMPReader::MODE_SIMPLE,
803803 'map_name' => 'CityDest',
804804 ),
805805 'Country' => array(
806 - 'map_group' => 'deprected',
 806+ 'map_group' => 'deprecated',
807807 'mode' => XMPReader::MODE_SIMPLE,
808808 'map_name' => 'CountryDest',
809809 ),
810810 'State' => array(
811 - 'map_group' => 'deprected',
 811+ 'map_group' => 'deprecated',
812812 'mode' => XMPReader::MODE_SIMPLE,
813813 'map_name' => 'ProvinceOrStateDest',
814814 ),
815815 'DateCreated' => array(
816 - 'map_group' => 'deprected',
817 - // marking as deprected as the xmp prop prefered
 816+ 'map_group' => 'deprecated',
 817+ // marking as deprecated as the xmp prop preferred
818818 'mode' => XMPReader::MODE_SIMPLE,
819819 'map_name' => 'DateTimeOriginal',
820820 'validate' => 'validateDate',
@@ -855,7 +855,7 @@
856856 'mode' => XMPReader::MODE_SIMPLE,
857857 ),
858858 'Category' => array(
859 - // Note, this prop is deprected, but in general
 859+ // Note, this prop is deprecated, but in general
860860 // group since it doesn't have a replacement.
861861 'map_group' => 'general',
862862 'mode' => XMPReader::MODE_SIMPLE,
@@ -869,7 +869,7 @@
870870 ),
871871 'http://iptc.org/std/Iptc4xmpCore/1.0/xmlns/' => array(
872872 'CountryCode' => array(
873 - 'map_group' => 'deprected',
 873+ 'map_group' => 'deprecated',
874874 'mode' => XMPReader::MODE_SIMPLE,
875875 'map_name' => 'CountryDestCode',
876876 ),
@@ -880,7 +880,7 @@
881881 /* Note: Scene not done. */
882882 /* Note: SubjectCode (iim 2:12) not done. */
883883 'Location' => array(
884 - 'map_group' => 'deprected',
 884+ 'map_group' => 'deprecated',
885885 'mode' => XMPReader::MODE_SIMPLE,
886886 'map_name' => 'SublocationDest',
887887 ),
@@ -920,7 +920,7 @@
921921 'mode' => XMPReader::MODE_SIMPLE,
922922 'structPart'=> true,
923923 ),
924 - 'CiEmailWork' => array( /* email (possibly seperated by ',') */
 924+ 'CiEmailWork' => array( /* email (possibly separated by ',') */
925925 'map_group' => 'general',
926926 'mode' => XMPReader::MODE_SIMPLE,
927927 'structPart'=> true,
@@ -940,7 +940,7 @@
941941 'mode' => XMPReader::MODE_SIMPLE,
942942 'structPart'=> true,
943943 ),
944 - 'CiUrlWork' => array( /* url. Multiple may be seperated by comma. */
 944+ 'CiUrlWork' => array( /* url. Multiple may be separated by comma. */
945945 'map_group' => 'general',
946946 'mode' => XMPReader::MODE_SIMPLE,
947947 'structPart'=> true,
Index: branches/img_metadata/phase3/includes/media/JpegMetadataExtractor.php
@@ -11,7 +11,7 @@
1212 // A jpeg file should never even remotely have
1313 // that many segments. Your average file has about 10.
1414
15 - /** Function to extract metadata segmants of interest from jpeg files
 15+ /** Function to extract metadata segments of interest from jpeg files
1616 * based on GIFMetadataExtractor.
1717 *
1818 * we can almost use getimagesize to do this
@@ -142,7 +142,7 @@
143143
144144 if ( substr( $app13, $offset, 4 ) !== '8BIM' ) {
145145 // its supposed to be 8BIM
146 - // but apperently sometimes isn't esp. in
 146+ // but apparently sometimes isn't esp. in
147147 // really old jpg's
148148 $valid = false;
149149 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74571Add support for most of the iptc4xmp stuffbawolff22:57, 9 October 2010

Status & tagging log