r74570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74569‎ | r74570 | r74571 >
Date:21:57, 9 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.4 - fixed issue caused by earlier refactoring
Modified paths:
  • /trunk/extensions/Validator/Validator.php (modified) (history)
  • /trunk/extensions/Validator/includes/criteria/CriterionItemCount.php (modified) (history)
  • /trunk/extensions/Validator/includes/criteria/CriterionUniqueItems.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/includes/criteria/CriterionItemCount.php
@@ -34,7 +34,7 @@
3535 /**
3636 * @see ParameterCriterion::validate
3737 */
38 - public function validate( Parameter $parameter ) {
 38+ public function validate( Parameter $parameter, array $parameters) {
3939 $count = count( $parameter->getValue() );
4040 return $count <= $this->upperBound && $count >= $this->lowerBound;
4141 }
Index: trunk/extensions/Validator/includes/criteria/CriterionUniqueItems.php
@@ -25,7 +25,7 @@
2626 /**
2727 * @see ParameterCriterion::validate
2828 */
29 - public function validate( Parameter $parameter ) {
 29+ public function validate( Parameter $parameter, array $parameters ) {
3030 return count( $parameter->getValue() ) == count( array_unique( $parameter->getValue() ) );
3131 }
3232
Index: trunk/extensions/Validator/Validator.php
@@ -24,7 +24,7 @@
2525 die( 'Not an entry point.' );
2626 }
2727
28 -define( 'Validator_VERSION', '0.4 beta 3' );
 28+define( 'Validator_VERSION', '0.4 beta 4' );
2929
3030 // Register the internationalization file.
3131 $wgExtensionMessagesFiles['Validator'] = dirname( __FILE__ ) . '/Validator.i18n.php';

Status & tagging log