r74498 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74497‎ | r74498 | r74499 >
Date:03:35, 8 October 2010
Author:kaldari
Status:deferred
Tags:
Comment:
setting letter defaults for letter templates
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php
@@ -56,7 +56,7 @@
5757 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-cc_form_letter', 'class' => 'payflowpro_gateway-cc_form_column'));
5858 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-cc_form_letter_inside' ));
5959
60 - $text_template = $wgRequest->getText( 'text_template' );
 60+ $text_template = $wgRequest->getText( 'text_template', '2010/JimmyAppealLong' );
6161 // if the user has uselang set, honor that, otherwise default to the language set for the form defined by 'language' in the query string
6262 if ( $wgRequest->getText( 'language' )) $text_template .= '/' . $this->form_data[ 'language' ];
6363
@@ -94,6 +94,16 @@
9595 // email
9696 $form .= $this->getEmailField();
9797
 98+ // amount
 99+ $form = '<tr>';
 100+ $form .= '<td colspan="2"><span class="creditcard-error-msg">' . $this->form_errors['invalidamount'] . '</span></td>';
 101+ $form .= '</tr>';
 102+ $form .= '<tr>';
 103+ $form .= '<td class="label">' . Xml::label(wfMsg( 'payflowpro_gateway-donor-amount' ), 'amount') . '</td>';
 104+ $form .= '<td>' . Xml::input( 'amount', '7', $this->form_data['amount'], array( 'type' => 'text', 'maxlength' => '10', 'id' => 'amount' ) ) .
 105+ ' ' . $this->generateCurrencyDropdown() . '</td>';
 106+ $form .= '</tr>';
 107+
98108 // card number
99109 $form .= $this->getCardNumberField();
100110
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -60,7 +60,7 @@
6161 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-cc_form_letter', 'class' => 'payflowpro_gateway-cc_form_column'));
6262 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-cc_form_letter_inside' ));
6363
64 - $text_template = $wgRequest->getText( 'text_template' );
 64+ $text_template = $wgRequest->getText( 'text_template', '2010/JimmyAppealLong' );
6565 // if the user has uselang set, honor that, otherwise default to the language set for the form defined by 'language' in the query string
6666 if ( $wgRequest->getText( 'language' )) $text_template .= '/' . $this->form_data[ 'language' ];
6767

Status & tagging log