r74453 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74452‎ | r74453 | r74454 >
Date:19:32, 7 October 2010
Author:kaldari
Status:deferred
Tags:
Comment:
formatting changes per Zach
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css
@@ -12,7 +12,7 @@
1313 }
1414
1515 #payflowpro_gateway-cc_form_form {
16 - width: 50%;
 16+ width: 475px;
1717 float: right;
1818 margin-left: 2em;
1919 padding-left: 2em;
@@ -24,7 +24,7 @@
2525 }
2626
2727 #payflowpro_gateway-cc_form_letter p {
28 - font-size: 1em;
 28+ font-size: 1.125em;
2929 margin-bottom: 1.2em;
3030 }
3131
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php
@@ -134,9 +134,9 @@
135135 global $wgRequest;
136136 $form = '';
137137 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' )); ;
138 - $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header','id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-cc-form-header-personal' ));
 138+ $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header','id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
139139 $sourceId = $wgRequest->getText( 'utm_source_id', 13 );
140 - $form .= Xml::Tags( 'p', array( 'id' => 'payflowpro_gateway-cc_otherways' ), wfMsg( 'payflowpro_gateway-paypal', $sourceId ));
 140+ $form .= Xml::Tags( 'p', array( 'id' => 'payflowpro_gateway-cc_otherways' ), wfMsg( 'payflowpro_gateway-paypal' ));
141141 $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
142142
143143 $form .= $this->generatePersonalFields();
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -80,7 +80,7 @@
8181 protected function generateBillingContainer() {
8282 $form = '';
8383 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' ));
84 - $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header','id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-cc-form-header-personal' ));
 84+ $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header','id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-make-your-donation' ));
8585 $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
8686 $form .= $this->generateBillingFields();
8787 $form .= Xml::closeElement( 'table' ); // close table#payflow-table-donor
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -97,11 +97,12 @@
9898 'payflowpro_gateway-question-comment' => 'Questions or comments? Contact: <a href="mailto:donate@wikimedia.org">donate@wikimedia.org</a>',
9999 'payflowpro_gateway-donate-click' => 'Your credit card will be securely processed.',
100100 'payflowpro_gateway-otherways' => 'There are <a href="http://wikimediafoundation.org/wiki/Ways_to_Give/en">other ways to give, including PayPal, check, or mail</a>.',
101 - 'payflowpro_gateway-paypal' => 'Have a PayPal account? <a href="https://payments.wikimedia.org/index.php/Special:PayflowProGateway?paypal=true&masthead=Jimmy-masthead&form_name=TwoColumnLetter&text_template=2010/JimmyAppealLong&language=en&utm_source=banner.cc$1.pp">Donate with PayPal</a>.',
 101+ 'payflowpro_gateway-paypal' => 'Have a PayPal account? <a href="https://payments.wikimedia.org/index.php/Special:PayflowProGateway?paypal=true&masthead=Jimmy-masthead&form_name=TwoColumnLetter&text_template=2010/JimmyAppealLong&language=en">Donate with PayPal</a>.',
102102 'payflowpro_gateway-credit-storage-processing' => 'We do not store your credit card information, and your personal data is subject to our <a href="http://wikimediafoundation.org/wiki/Donor_Privacy_Policy">privacy policy</a>.',
103103 'payflowpro_gateway-token-mismatch' => 'Your session has expired. Please try filling out and submitting the form again.',
104104 'payflowpro_gateway-cc-form-header-personal' => 'Billing information',
105105 'payflowpro_gateway-cc-form-header-payment' => 'Payment information',
 106+ 'payflowpro_gateway-make-your-donation' => 'Make your donation now',
106107 'payflowpro_gateway-state-in-us' => 'if inside the US',
107108 'payflowpro_gateway-comment' => 'Comment',
108109 );
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.css
@@ -44,6 +44,7 @@
4545 }
4646
4747 #payflow-table-donor {
 48+ background-color: transparent;
4849 }
4950
5051 #payflow-table-donor td.label, #payflow-table-comment td.label, #payflow-table-cc td.label {

Status & tagging log