r74419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74418‎ | r74419 | r74420 >
Date:12:48, 7 October 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Stop spamming. Reason was found and it was valid (AggregateMessageGroup iterators over all groups)
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -755,7 +755,7 @@
756756 return $this->getDefinitions();
757757 }
758758
759 - else return array();
 759+ return array();
760760 }
761761
762762 /**
@@ -769,9 +769,6 @@
770770 public function getMessage( $key, $code ) {
771771 if ( $code === 'en' ) {
772772 $stuff = $this->load( 'en' );
773 - if ( !isset( $stuff[$key] ) ) {
774 - wfWarn( __METHOD__ . " called for unknown key $key from " . wfGetAllCallers( 6 ) );
775 - }
776773 return isset( $stuff[$key] ) ? $stuff[$key] : null;
777774 }
778775

Status & tagging log