r74380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74379‎ | r74380 | r74381 >
Date:19:05, 6 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Improved on r74282 and r74333 in response to CR comments.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.placeholder.js (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.specials.preferences.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.placeholder.js
@@ -16,7 +16,7 @@
1717 // Otherwise, use a combination of blur and focus event handlers and a placeholder class
1818 else {
1919 jQuery(this).each( function() {
20 - $input = jQuery(this);
 20+ var $input = jQuery(this);
2121 $input
2222 // Show on blur if empty
2323 .bind( 'blur', function() {
Index: trunk/phase3/resources/mediawiki/mediawiki.specials.preferences.js
@@ -2,14 +2,14 @@
33 * JavaScript for Special:Preferences
44 */
55
6 -$( '#prefsubmit' ).attr( 'id', 'prefcontrol' ).end()
 6+$( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
77 $( '#preferences' )
88 .addClass( 'jsprefs' )
99 .before( $( '<ul id="preftoc"></ul>' ) )
10 - .find( '> fieldset' )
 10+ .children( 'fieldset' )
1111 .hide()
1212 .addClass( 'prefsection' )
13 - .find( '> legend' )
 13+ .children( 'legend' )
1414 .addClass( 'mainLegend' )
1515 .each( function( i ) {
1616 $(this).parent().attr( 'id', 'prefsection-' + i );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74282Moved some of the functionality from mediawiki.legacy.prefs into mediawiki.sp...tparscal22:16, 4 October 2010
r74333Moved the HTML5 placeholder attribute emulation in ext.vector.simpleSearch in...tparscal23:24, 5 October 2010

Status & tagging log