| Index: trunk/extensions/CodeReview/CodeReview.php |
| — | — | @@ -173,10 +173,8 @@ |
| 174 | 174 | $updater->addExtensionUpdate( array( 'addField', 'code_rev', 'cr_diff', "$base/archives/codereview-cr_diff.sql", true ) ); |
| 175 | 175 | $updater->addExtensionUpdate( array( 'addIndex', 'code_relations', 'repo_to_from', "$base/archives/code_relations_index.sql", true ) ); |
| 176 | 176 | |
| 177 | | - // $updater->addExtensionUpdate( array( 'addField', 'code_rev', 'cr_status', "$base/archives/codereview-cr_status.sql", true ) ); // FIXME FIXME this is a change to options... don't know how |
| 178 | | - |
| 179 | | - if ( !$updater->updateRowExists( 'add old to code_rev enum' ) ) { |
| 180 | | - $updater->addExtensionUpdate( array( 'modifyField', 'code_rev', 'cr_status', "$base/archives/codereview-cr_old_status.sql", true ) ); |
| | 177 | + if ( !$updater->updateRowExists( 'make cr_status varchar' ) ) { |
| | 178 | + $updater->addExtensionUpdate( array( 'modifyField', 'code_rev', 'cr_status', "$base/archives/codereview-cr_status_varchar.sql", true ) ); |
| 181 | 179 | } |
| 182 | 180 | |
| 183 | 181 | $updater->addExtensionUpdate( array( 'addTable', 'code_bugs', "$base/archives/code_bugs.sql", true ) ); |
| Index: trunk/extensions/CodeReview/archives/codereview-cr_status.sql |
| — | — | @@ -1,4 +0,0 @@ |
| 2 | | -ALTER TABLE /*$wgDBprefix*/code_rev |
| 3 | | - CHANGE `cr_status` `cr_status` |
| 4 | | - ENUM( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred' ) |
| 5 | | - NOT NULL DEFAULT 'new'; |
| Index: trunk/extensions/CodeReview/archives/codereview-cr_old_status.sql |
| — | — | @@ -1,6 +0,0 @@ |
| 2 | | -ALTER TABLE /*$wgDBprefix*/code_rev |
| 3 | | - CHANGE `cr_status` `cr_status` |
| 4 | | - ENUM( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old' ) |
| 5 | | - NOT NULL DEFAULT 'new'; |
| 6 | | - |
| 7 | | -INSERT INTO /*$wgDBprefix*/updatelog( ul_key ) VALUES( 'add old to code_rev enum' ); |
| \ No newline at end of file |
| Index: trunk/extensions/CodeReview/archives/codereview-cr_status_varchar.sql |
| — | — | @@ -0,0 +1,5 @@ |
| | 2 | +ALTER TABLE /*$wgDBprefix*/code_rev |
| | 3 | + MODIFY `cr_status` |
| | 4 | + VARCHAR(25) NOT NULL DEFAULT 'new'; |
| | 5 | + |
| | 6 | +INSERT INTO /*$wgDBprefix*/updatelog( ul_key ) VALUES( 'make cr_status varchar' ); |
| \ No newline at end of file |
| Property changes on: trunk/extensions/CodeReview/archives/codereview-cr_status_varchar.sql |
| ___________________________________________________________________ |
| Added: svn:eol-style |
| 1 | 7 | + native |
| Index: trunk/extensions/CodeReview/codereview.sql |
| — | — | @@ -46,15 +46,7 @@ |
| 47 | 47 | cr_message blob, |
| 48 | 48 | |
| 49 | 49 | -- Status key for how this thang is... |
| 50 | | - -- 'new': Hasn't yet been reviewed |
| 51 | | - -- 'fixme': This revision has some problem which needs to be resolved |
| 52 | | - -- 'reverted': Was completely reverted by a later revision |
| 53 | | - -- 'resolved': Issues with this rev have been since resolved |
| 54 | | - -- 'ok': Reviewed, no issues spotted |
| 55 | | - -- 'verified': Reviewed and tested, no issues spotted |
| 56 | | - -- 'deferred': Not reviewed at this time (usually non-Wikimedia extension) |
| 57 | | - -- 'old': Predates the extension/doesn't require review |
| 58 | | - cr_status enum('new', 'fixme', 'reverted', 'resolved', 'ok', 'verified', 'deferred', 'old') not null default 'new', |
| | 50 | + cr_status varchar(25) not null default 'new', |
| 59 | 51 | |
| 60 | 52 | -- Base path of this revision : |
| 61 | 53 | -- * if the revision change only one file, the file path |