r74297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74296‎ | r74297 | r74298 >
Date:13:31, 5 October 2010
Author:catrope
Status:deferred
Tags:
Comment:
Remove unnecessary parameters for SpecialSessionStash in SpecialPage.php, and correct a comment in SessionStash.php
Modified paths:
  • /branches/uploadwizard/phase3/includes/SpecialPage.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/upload/SessionStash.php (modified) (history)

Diff [purge]

Index: branches/uploadwizard/phase3/includes/upload/SessionStash.php
@@ -121,7 +121,7 @@
122122 }
123123 $stashPath = $status->value;
124124
125 - // required info we always store. Must trump any other application info in data()
 125+ // required info we always store. Must trump any other application info in $data
126126 // 'mTempPath', 'mFileSize', and 'mFileProps' are arbitrary names
127127 // chosen for compatibility with UploadBase's way of doing this.
128128 $requiredData = array(
Index: branches/uploadwizard/phase3/includes/SpecialPage.php
@@ -149,7 +149,7 @@
150150 'MIMEsearch' => array( 'SpecialPage', 'MIMEsearch' ),
151151 'FileDuplicateSearch' => array( 'SpecialPage', 'FileDuplicateSearch' ),
152152 'Upload' => 'SpecialUpload',
153 - 'SessionStash' => array( 'SpecialSessionStash', 'SessionStash', 'upload' ),
 153+ 'SessionStash' => 'SpecialSessionStash',
154154
155155 # Wiki data and tools
156156 'Statistics' => 'SpecialStatistics',

Status & tagging log