r74220 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74219‎ | r74220 | r74221 >
Date:16:06, 3 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.7 - some fixes
Modified paths:
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_ParamOLLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_ParamOLLayers.php
@@ -33,7 +33,7 @@
3434
3535 $unpacked = array();
3636
37 - foreach ( $parameter->value as $layerOrGroup ) {
 37+ foreach ( $parameter->getValue() as $layerOrGroup ) {
3838 if ( array_key_exists( $layerOrGroup, $egMapsOLLayerGroups ) ) {
3939 $unpacked = array_merge( $unpacked, $egMapsOLLayerGroups[$layerOrGroup] );
4040 }
@@ -42,7 +42,7 @@
4343 }
4444 }
4545
46 - $parameter->value = $unpacked;
 46+ $parameter->setValue( $unpacked );
4747 }
4848
4949 }
\ No newline at end of file
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php
@@ -41,7 +41,7 @@
4242 * @since 0.7
4343 */
4444 public function addParameterInfo( array &$params ) {
45 - global $egMapsOLLayers, $egMapsOLControls, $egMapsOpenLayersZoom;
 45+ global $egMapsOLLayers, $egMapsOLControls;
4646
4747 $params['zoom']->addCriteria( new CriterionInRange( 0, 19 ) );
4848 $params['zoom']->setDefault( self::getDefaultZoom() );

Status & tagging log