r74199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74198‎ | r74199 | r74200 >
Date:11:23, 3 October 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.7 - Minor fix, added todo and updated release notes
Modified paths:
  • /trunk/extensions/SemanticMaps/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/RELEASE-NOTES
@@ -1,12 +1,20 @@
22 For a documentation of all features, see http://www.mediawiki.org/wiki/Extension:Semantic_Maps
33
44 == Semantic Maps change log ==
 5+
56 This change log contains a list of completed to-do's (new features, bug fixes, refactoring) for every
67 version of Semantic Maps. You can find the most upt-do-date version at
78 http://www.mediawiki.org/wiki/Extension:Semantic_Maps/Version_history#Semantic_Maps_change_log
89
910
10 -=== Maps 0.6.6 ===
 11+=== Semantic Maps 0.7 ===
 12+(2010-10-xx)
 13+
 14+=== ===
 15+
 16+*
 17+
 18+=== Semantic Maps 0.6.6 ===
1119 (2010-08-26)
1220
1321 === New features ===
Index: trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php
@@ -21,6 +21,8 @@
2222 * Set the default format to 'map' when the requested properties are
2323 * of type geographic coordinates.
2424 *
 25+ * TODO: have a setting to turn this off and have it off by default for #show
 26+ *
2527 * @since 0.6.5
2628 *
2729 * @param $format Mixed: The format (string), or false when not set yet
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -160,7 +160,7 @@
161161 * and finally by the specific parameters (the ones specific to a service-feature combination).
162162 */
163163 $parameterInfo = array_merge_recursive( MapsMapper::getCommonParameters(), $this->featureParameters );
164 - $parameterInfo = array_merge_recursive( $parameterInfo, $this->service->getParameterInfo() );
 164+ $this->service->addParameterInfo( $parameterInfo );
165165 $parameterInfo = array_merge_recursive( $parameterInfo, $this->getSpecificParameterInfo() );
166166
167167 $validator = new Validator( $this->getName() );

Status & tagging log