r74172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74171‎ | r74172 | r74173 >
Date:22:42, 2 October 2010
Author:siebrand
Status:ok
Tags:
Comment:
Remove comments related to no longer existent and relevant compatibility function for array_diff_key().
Modified paths:
  • /trunk/phase3/includes/LinksUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LinksUpdate.php
@@ -351,8 +351,6 @@
352352 function getLinkInsertions( $existing = array() ) {
353353 $arr = array();
354354 foreach( $this->mLinks as $ns => $dbkeys ) {
355 - # array_diff_key() was introduced in PHP 5.1, there is a compatibility function
356 - # in GlobalFunctions.php
357355 $diffs = isset( $existing[$ns] ) ? array_diff_key( $dbkeys, $existing[$ns] ) : $dbkeys;
358356 foreach ( $diffs as $dbk => $id ) {
359357 $arr[] = array(
@@ -515,8 +513,6 @@
516514 function getInterwikiInsertions( $existing = array() ) {
517515 $arr = array();
518516 foreach( $this->mInterwikis as $prefix => $dbkeys ) {
519 - # array_diff_key() was introduced in PHP 5.1, there is a compatibility function
520 - # in GlobalFunctions.php
521517 $diffs = isset( $existing[$prefix] ) ? array_diff_key( $dbkeys, $existing[$prefix] ) : $dbkeys;
522518 foreach ( $diffs as $dbk => $id ) {
523519 $arr[] = array(
@@ -529,8 +525,6 @@
530526 return $arr;
531527 }
532528
533 -
534 -
535529 /**
536530 * Given an array of existing links, returns those links which are not in $this
537531 * and thus should be deleted.

Status & tagging log