r74146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74145‎ | r74146 | r74147 >
Date:16:54, 2 October 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Fix logic error in IMS check introduced in r72940. Was sending 304 even for modified files
Modified paths:
  • /trunk/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoader.php
@@ -293,7 +293,7 @@
294294
295295 // If there's an If-Modified-Since header, respond with a 304 appropriately
296296 $ims = $context->getRequest()->getHeader( 'If-Modified-Since' );
297 - if ( $ims !== false && $mtime >= wfTimestamp( TS_UNIX, $ims ) ) {
 297+ if ( $ims !== false && $mtime <= wfTimestamp( TS_UNIX, $ims ) ) {
298298 header( 'HTTP/1.0 304 Not Modified' );
299299 header( 'Status: 304 Not Modified' );
300300 wfProfileOut( __METHOD__ );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72940* Changed the expiry time strategy, now treating any request to ResourceLoade...tparscal23:19, 13 September 2010

Status & tagging log