r74144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74143‎ | r74144 | r74145 >
Date:15:59, 2 October 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Really fix PHP warnings when trying to export AggregateMessageGroup
Modified paths:
  • /trunk/extensions/Translate/TranslateTasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateTasks.php
@@ -372,10 +372,10 @@
373373
374374 public function output() {
375375 if ( $this->group instanceof MessageGroupBase ) {
376 - $ffs = $this->group->getFFS();
377 - if ( !$ffs ) {
 376+ if ( !$this->group instanceof FileBasedMessageGroup ) {
378377 $data = 'Not supported';
379378 } else {
 379+ $ffs = $this->group->getFFS();
380380 $data = $ffs->writeIntoVariable( $this->collection );
381381 }
382382 } else {

Status & tagging log