r74133 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74132‎ | r74133 | r74134 >
Date:08:04, 2 October 2010
Author:ialex
Status:ok
Tags:
Comment:
__FUNCTION__ -> __METHOD__
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -53,7 +53,7 @@
5454
5555 if ( ( $this->nrows = oci_fetch_all( $stmt, $this->rows, 0, - 1, OCI_FETCHSTATEMENT_BY_ROW | OCI_NUM ) ) === false ) {
5656 $e = oci_error( $stmt );
57 - $db->reportQueryError( $e['message'], $e['code'], '', __FUNCTION__ );
 57+ $db->reportQueryError( $e['message'], $e['code'], '', __METHOD__ );
5858 return;
5959 }
6060
@@ -305,14 +305,14 @@
306306
307307 if ( ( $this->mLastResult = $stmt = oci_parse( $this->mConn, $sql ) ) === false ) {
308308 $e = oci_error( $this->mConn );
309 - $this->reportQueryError( $e['message'], $e['code'], $sql, __FUNCTION__ );
 309+ $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ );
310310 return false;
311311 }
312312
313313 if ( !oci_execute( $stmt, $this->execFlags() ) ) {
314314 $e = oci_error( $stmt );
315315 if ( !$this->ignore_DUP_VAL_ON_INDEX || $e['code'] != '1' ) {
316 - $this->reportQueryError( $e['message'], $e['code'], $sql, __FUNCTION__ );
 316+ $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ );
317317 return false;
318318 }
319319 }
Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -152,7 +152,7 @@
153153 if ( $stmt == false ) {
154154 $message = "A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: http://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script\n" .
155155 "Query: " . htmlentities( $sql ) . "\n" .
156 - "Function: " . __FUNCTION__ . "\n";
 156+ "Function: " . __METHOD__ . "\n";
157157 // process each error (our driver will give us an array of errors unlike other providers)
158158 foreach ( sqlsrv_errors() as $error ) {
159159 $message .= $message . "ERROR[" . $error['code'] . "] " . $error['message'] . "\n";

Status & tagging log