r74121 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r74120‎ | r74121 | r74122 >
Date:22:59, 1 October 2010
Author:platonides
Status:ok
Tags:
Comment:
Remove suite included twice in suite.xml
Rename MediaWikiParserTestSuite class to MediaWikiParserTest. This way, it matches its file basename, which makes phpunit not to consider, when loading MediaWikiParserText.php, the ParserUnitTest (coming from ParserHelpers.php require) as a standalone test class, which is what was producing the warning: No tests found in class "ParserUnitTest".

All tests pass for me now:
Tests: 752, Assertions: 3706, Incomplete: 2.

Incomplete tests are testApiListPages() and testWatchRollback()
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/parser/MediaWikiParserTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/suite.xml (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/parser/MediaWikiParserTest.php
——@@ -2,7 +2,7 @@
33
44 require_once( dirname( __FILE__ ) . '/ParserHelpers.php' );
55
6 -class MediaWikiParserTestSuite extends PHPUnit_Framework_TestSuite {
 6+class MediaWikiParserTest extends PHPUnit_Framework_TestSuite {
77 private $count;
88 public $backend;
99
Index: trunk/phase3/maintenance/tests/phpunit/suite.xml
——@@ -11,9 +11,6 @@
1212 <testsuite name="includes">
1313 <directory>./includes</directory>
1414 </testsuite>
15 - <testsuite name="includes">
16 - <directory>./includes</directory>
17 - </testsuite>
1815 <testsuite name="languages">
1916 <directory>./languages</directory>
2017 </testsuite>

Status & tagging log