r74116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74115‎ | r74116 | r74117 >
Date:22:13, 1 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed mistake in r73686 where I wrapped CSS in a JavaScript conditional.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2323,9 +2323,7 @@
23242324 $context = new ResourceLoaderContext( $this->mResourceLoader, new FauxRequest( $query ) );
23252325 if ( $only == 'styles' ) {
23262326 $links .= Html::inlineStyle(
2327 - ResourceLoader::makeLoaderConditionalScript(
2328 - $this->mResourceLoader->makeModuleResponse( $context, $modules )
2329 - )
 2327+ $this->mResourceLoader->makeModuleResponse( $context, $modules )
23302328 );
23312329 } else {
23322330 $links .= Html::inlineScript(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73686* Fixed bug #25281 by adding special treatment for modules in the "private" g...tparscal22:10, 24 September 2010

Status & tagging log