r74107 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74106‎ | r74107 | r74108 >
Date:20:46, 1 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Removed double-encoding of dependencies and group for custom loader scripts.
Modified paths:
  • /trunk/phase3/includes/ResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoaderModule.php
@@ -1060,8 +1060,8 @@
10611061 foreach ( $context->getResourceLoader()->getModules() as $name => $module ) {
10621062 // Support module loader scripts
10631063 if ( ( $loader = $module->getLoaderScript() ) !== false ) {
1064 - $deps = FormatJson::encode( $module->getDependencies() );
1065 - $group = FormatJson::encode( $module->getGroup() );
 1064+ $deps = $module->getDependencies();
 1065+ $group = $module->getGroup();
10661066 $version = wfTimestamp( TS_ISO_8601_BASIC, round( $module->getModifiedTime( $context ), -2 ) );
10671067 $out .= ResourceLoader::makeCustomLoaderScript( $name, $version, $deps, $group, $loader );
10681068 }

Status & tagging log