r74088 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74087‎ | r74088 | r74089 >
Date:19:22, 1 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Improved on r73046 by removing asumption of $ === jQuery.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tabIndex.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tabIndex.js
@@ -5,8 +5,8 @@
66 */
77 jQuery.fn.firstTabIndex = function() {
88 var minTabIndex = 0;
9 - $(this).find( '[tabindex]' ).each( function() {
10 - var tabIndex = parseInt( $(this).attr( 'tabindex' ) );
 9+ jQuery(this).find( '[tabindex]' ).each( function() {
 10+ var tabIndex = parseInt( jQuery(this).attr( 'tabindex' ) );
1111 if ( tabIndex > minTabIndex ) {
1212 minTabIndex = tabIndex;
1313 }
@@ -20,8 +20,8 @@
2121 */
2222 jQuery.fn.lastTabIndex = function() {
2323 var maxTabIndex = 0;
24 - $(this).find( '[tabindex]' ).each( function() {
25 - var tabIndex = parseInt( $(this).attr( 'tabindex' ) );
 24+ jQuery(this).find( '[tabindex]' ).each( function() {
 25+ var tabIndex = parseInt( jQuery(this).attr( 'tabindex' ) );
2626 if ( tabIndex > maxTabIndex ) {
2727 maxTabIndex = tabIndex;
2828 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r81264Wrapping core modules (FIXME from r79929)...krinkle19:33, 31 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73046Added collapsible tabs plugin, reworked tabIndex functions, and fixed some sy...tparscal02:03, 15 September 2010

Status & tagging log