r74080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74079‎ | r74080 | r74081 >
Date:17:39, 1 October 2010
Author:tparscal
Status:ok
Tags:
Comment:
Resolved issues in r73026, namely a confusing comment and a missing var keyword.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -55,9 +55,8 @@
5656 * An object which allows single and multiple get/set/exists functionality on a list of key / value pairs
5757 *
5858 * @param {boolean} global whether to get/set/exists values on the window object or a private object
59 - * @param {function} parser function to perform extra processing before while getting a value which accepts
60 - * value and options parameters where value is a string to be parsed and options is an object of options for the
61 - * parser
 59+ * @param {function} parser function to perform extra processing; in the form of function( value, options )
 60+ * where value is the data to be parsed and options is additional data passed through to the parser
6261 */
6362 'configuration': function( global, parser ) {
6463
@@ -87,7 +86,7 @@
8887 this.get = function( selection, options ) {
8988 if ( typeof selection === 'object' ) {
9089 var results = {};
91 - for ( s in selection ) {
 90+ for ( var s in selection ) {
9291 if ( selection.hasOwnProperty( s ) ) {
9392 if ( typeof s === 'string' ) {
9493 return that.get( values[s], selection[s] );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73026* Refactored mediaWiki.msg to use the configuration prototype...tparscal22:28, 14 September 2010

Status & tagging log